Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11660011: Clean up CodeObservers (Closed)

Created:
8 years ago by Max Heinritz (Google)
Modified:
8 years ago
Reviewers:
siva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Clean up CodeObservers Move CodeObserver registration to the OS abstraction. Move Pprof logic to the OS abstraction. Remove pprof from VM tests because now pprof logic is in the VM itself. Add DISALLOW and AllStatic to Code Observers where appropriate. Previous review: https://codereview.chromium.org/11572032/ BUG=7321 Committed: https://code.google.com/p/dart/source/detail?r=16462

Patch Set 1 #

Patch Set 2 : Leave Pprof symbols in API for now, add TODO to change when Dartium no longer uses them. #

Total comments: 2

Patch Set 3 : Add a period to a comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+396 lines, -331 lines) Patch
M runtime/bin/main.cc View 6 chunks +0 lines, -35 lines 0 comments Download
M runtime/bin/run_vm_tests.cc View 4 chunks +4 lines, -41 lines 0 comments Download
M runtime/vm/code_observers.h View 4 chunks +9 lines, -1 line 0 comments Download
M runtime/vm/code_observers.cc View 2 chunks +6 lines, -121 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 1 chunk +7 lines, -26 lines 0 comments Download
D runtime/vm/debuginfo_macos.cc View 1 chunk +0 lines, -50 lines 0 comments Download
D runtime/vm/debuginfo_win.cc View 1 chunk +0 lines, -50 lines 0 comments Download
M runtime/vm/isolate.cc View 1 2 3 chunks +4 lines, -5 lines 0 comments Download
M runtime/vm/os.h View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/os_android.cc View 2 chunks +176 lines, -0 lines 0 comments Download
M runtime/vm/os_linux.cc View 2 chunks +176 lines, -0 lines 0 comments Download
M runtime/vm/os_macos.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/os_win.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/vm/vm_sources.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Max Heinritz (Google)
I create a new review. Two changes this time: 1) Added pprof symbols back to ...
8 years ago (2012-12-21 18:51:27 UTC) #1
siva
lgtm
8 years ago (2012-12-22 00:21:01 UTC) #2
siva
8 years ago (2012-12-22 00:21:02 UTC) #3 
lgtm

Powered by Google App Engine
This is Rietveld 408576698