Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 1164463005: Rename some service protocol errors. (Closed)

Created:
5 years, 6 months ago by turnidge
Modified:
5 years, 6 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : More better #

Patch Set 3 : Fix typo in dox #

Patch Set 4 : Reconsider names / edit dox #

Patch Set 5 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -39 lines) Patch
M runtime/observatory/lib/src/elements/cpu_profile.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/debugger.dart View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/script_inset.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 2 3 2 chunks +4 lines, -5 lines 0 comments Download
M runtime/vm/json_stream.h View 1 2 3 2 chunks +4 lines, -5 lines 0 comments Download
M runtime/vm/json_stream.cc View 1 2 3 1 chunk +4 lines, -6 lines 0 comments Download
M runtime/vm/profiler_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/service.cc View 1 2 3 3 chunks +9 lines, -3 lines 0 comments Download
M runtime/vm/service/service.md View 1 2 3 9 chunks +16 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
turnidge
5 years, 6 months ago (2015-05-29 21:00:12 UTC) #2
rmacnak
LGTM
5 years, 6 months ago (2015-05-29 21:13:32 UTC) #3
turnidge
5 years, 6 months ago (2015-06-01 16:27:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
f6d3d4681de6706edf2243745d5bf90658c9f6db (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698