Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Unified Diff: runtime/vm/service.cc

Issue 1164463005: Rename some service protocol errors. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: sync Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/profiler_service.cc ('k') | runtime/vm/service/service.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service.cc
diff --git a/runtime/vm/service.cc b/runtime/vm/service.cc
index 3f0e23e619c49eb5d536c80f0b66dd28cb7d2362..ef3d12e14574c16e26bd23e49ce9a6e3c2fef72c 100644
--- a/runtime/vm/service.cc
+++ b/runtime/vm/service.cc
@@ -1810,7 +1810,9 @@ static bool AddBreakpoint(Isolate* isolate, JSONStream* js) {
Breakpoint* bpt =
isolate->debugger()->SetBreakpointAtLine(script_url, line);
if (bpt == NULL) {
- js->PrintError(kNoBreakAtLine, NULL);
+ js->PrintError(kCannotAddBreakpoint,
+ "%s: Cannot add breakpoint at line '%s'",
+ js->method(), line_param);
return true;
}
bpt->PrintJSON(js);
@@ -1836,7 +1838,9 @@ static bool AddBreakpointAtEntry(Isolate* isolate, JSONStream* js) {
Breakpoint* bpt =
isolate->debugger()->SetBreakpointAtEntry(function, false);
if (bpt == NULL) {
- js->PrintError(kNoBreakAtFunction, NULL);
+ js->PrintError(kCannotAddBreakpoint,
+ "%s: Cannot add breakpoint at function '%s'",
+ js->method(), function.ToCString());
return true;
}
bpt->PrintJSON(js);
@@ -1862,7 +1866,9 @@ static bool AddBreakpointAtActivation(Isolate* isolate, JSONStream* js) {
Breakpoint* bpt =
isolate->debugger()->SetBreakpointAtActivation(closure);
if (bpt == NULL) {
- js->PrintError(kNoBreakAtFunction, NULL);
+ js->PrintError(kCannotAddBreakpoint,
+ "%s: Cannot add breakpoint at activation",
+ js->method());
return true;
}
bpt->PrintJSON(js);
« no previous file with comments | « runtime/vm/profiler_service.cc ('k') | runtime/vm/service/service.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698