Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11642035: Renaming Window to WindowBase and LocalWindow to Window. (Closed)

Created:
8 years ago by blois
Modified:
8 years ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Renaming Window to WindowBase and LocalWindow to Window. Ditto for LocalHistory and LocalLocation. http://code.google.com/p/dart/issues/detail?id=7516 Committed: https://code.google.com/p/dart/source/detail?r=16401

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9080 lines, -9075 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 2 40 chunks +2850 lines, -2848 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 108 chunks +6137 lines, -6133 lines 0 comments Download
M sdk/lib/html/scripts/generator.py View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/html/scripts/htmldartgenerator.py View 1 2 2 chunks +7 lines, -7 lines 0 comments Download
M sdk/lib/html/scripts/htmlrenamer.py View 1 2 3 chunks +10 lines, -12 lines 2 comments Download
M sdk/lib/html/src/CrossFrameTypes.dart View 1 2 7 chunks +15 lines, -15 lines 0 comments Download
M sdk/lib/html/src/dart2js_Conversions.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/src/dart2js_DOMImplementation.dart View 1 2 6 chunks +13 lines, -13 lines 0 comments Download
M sdk/lib/html/src/dart2js_KeyEvent.dart View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/html/src/dart2js_LocationWrapper.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/src/dartium_KeyEvent.dart View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/html/src/native_DOMImplementation.dart View 1 2 3 chunks +9 lines, -8 lines 0 comments Download
M sdk/lib/html/templates/html/dart2js/html_dart2js.darttemplate View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/templates/html/dart2js/impl_KeyboardEvent.darttemplate View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M sdk/lib/html/templates/html/dart2js/impl_Window.darttemplate View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/html/templates/html/dartium/html_dartium.darttemplate View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/cross_frame_test.dart View 1 2 3 chunks +20 lines, -20 lines 0 comments Download
M tests/html/fileapi_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
blois
8 years ago (2012-12-20 01:59:18 UTC) #1
sra1
lgtm https://codereview.chromium.org/11642035/diff/10004/sdk/lib/html/scripts/htmlrenamer.py File sdk/lib/html/scripts/htmlrenamer.py (right): https://codereview.chromium.org/11642035/diff/10004/sdk/lib/html/scripts/htmlrenamer.py#newcode111 sdk/lib/html/scripts/htmlrenamer.py:111: 'Window.getComputedStyle', Move to keep sorted.
8 years ago (2012-12-20 02:19:18 UTC) #2
Emily Fortuna
sweet! This is a great change! :-) lgtm https://codereview.chromium.org/11642035/diff/10004/sdk/lib/html/scripts/htmlrenamer.py File sdk/lib/html/scripts/htmlrenamer.py (right): https://codereview.chromium.org/11642035/diff/10004/sdk/lib/html/scripts/htmlrenamer.py#newcode111 sdk/lib/html/scripts/htmlrenamer.py:111: 'Window.getComputedStyle', ...
8 years ago (2012-12-20 18:26:23 UTC) #3
Andrei Mouravski
8 years ago (2012-12-20 19:41:02 UTC) #4 
lgtm

Powered by Google App Engine
This is Rietveld 408576698