sdk/lib/html/scripts/generator.py - Issue 11642035: Renaming Window to WindowBase and LocalWindow to Window.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/html/scripts/generator.py

Issue 11642035: Renaming Window to WindowBase and LocalWindow to Window. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/html/scripts/generator.py

diff --git a/sdk/lib/html/scripts/generator.py b/sdk/lib/html/scripts/generator.py

index 707814715332a56f610f193426eaa4b96d94154c..070b2faf98c1cd98b9c66eea471e10df41929337 100644

--- a/sdk/lib/html/scripts/generator.py

+++ b/sdk/lib/html/scripts/generator.py

@@ -508,7 +508,7 @@ dart2js_conversions = {

# as well. Note, there are no functions that take a non-local Window

# as a parameter / setter.

'DOMWindow get':

- Conversion('_convertNativeToDart_Window', 'dynamic', 'Window'),

+ Conversion('_convertNativeToDart_Window', 'dynamic', 'WindowBase'),

'EventTarget get':

Conversion('_convertNativeToDart_EventTarget', 'dynamic',

'EventTarget'),

@@ -619,7 +619,7 @@ dart2js_annotations = {

# Methods returning Window can return a local window, or a cross-frame

# window (=Object) that needs wrapping.

'DOMWindow':

- "@Creates('LocalWindow|=Object') @Returns('LocalWindow|=Object')",

+ "@Creates('Window|=Object') @Returns('Window|=Object')",

'DOMWindow.openDatabase': "@Creates('Database') @Creates('DatabaseSync')",

« no previous file with comments | « sdk/lib/html/dartium/html_dartium.dart ('k') | sdk/lib/html/scripts/htmldartgenerator.py » ('j') | sdk/lib/html/scripts/htmlrenamer.py » ('J')