Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1162603006: Element model cleanup + prepare for easier reimplementation. (Closed)

Created:
5 years, 6 months ago by Johnni Winther
Modified:
5 years, 6 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Element model cleanup + prepare for easier reimplementation. BUG= R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/3b529003084bc2e9ddd3f6a336365ec16b2a4400

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+582 lines, -422 lines) Patch
M pkg/compiler/lib/src/compile_time_constants.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 2 chunks +7 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 3 chunks +3 lines, -3 lines 0 comments Download
A pkg/compiler/lib/src/elements/common.dart View 1 chunk +473 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 12 chunks +30 lines, -35 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 25 chunks +45 lines, -361 lines 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/closure_tracer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/list_tracer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/map_tracer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/constructors.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/scanner/class_element_parser.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/use_unused_api.dart View 2 chunks +8 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/world.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
5 years, 6 months ago (2015-06-01 09:57:36 UTC) #2
karlklose
LGTM.
5 years, 6 months ago (2015-06-01 10:53:04 UTC) #3
Johnni Winther
5 years, 6 months ago (2015-06-01 13:00:59 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
3b529003084bc2e9ddd3f6a336365ec16b2a4400 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698