pkg/compiler/lib/src/js_backend/constant_emitter.dart - Issue 1162603006: Element model cleanup + prepare for easier reimplementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/constant_emitter.dart

Issue 1162603006: Element model cleanup + prepare for easier reimplementation. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_backend/constant_emitter.dart

diff --git a/pkg/compiler/lib/src/js_backend/constant_emitter.dart b/pkg/compiler/lib/src/js_backend/constant_emitter.dart

index f01f0d079e3ad55a3aae269686186f767e5a95dc..b113d2409c116face6a1c46e6fe3ec4f641d6111 100644

--- a/pkg/compiler/lib/src/js_backend/constant_emitter.dart

+++ b/pkg/compiler/lib/src/js_backend/constant_emitter.dart

@@ -270,7 +270,7 @@ class ConstantEmitter

@override

jsAst.Expression visitConstructed(ConstructedConstantValue constant, [_]) {

Element element = constant.type.element;

- if (element.isForeign(backend)

+ if (backend.isForeign(element)

&& element.name == 'JS_CONST') {

StringConstantValue str = constant.fields.values.single;

String value = str.primitiveValue.slowToString();