Fix http://dartbug.com/23578:

Fix http://dartbug.com/23578:
- Complete revamp of isolate-specific flags.
- Associate flags with the isolate on creation.
- Dart_CreateIsolate and associate callback do take an
  extra flags argument.
- Make sure to clear IC data array when clearing code.

BUG=23578
Committed: https://github.com/dart-lang/sdk/commit/f5e3f94019a378455a59174c931cf0cb5b5cb212

[Ivan Posva, 2015-06-07 12:16:00]

iposva@google.com changed reviewers:
+ asiva@google.com, fschneider@google.com

[Ivan Posva, 2015-06-07 15:56:34]

TBR to give enough time to cycle on the bots...

-Ivan

[Ivan Posva, 2015-06-07 15:57:41]

Committed patchset #2 (id:20001) manually as
f5e3f94019a378455a59174c931cf0cb5b5cb212 (presubmit successful).

[Florian Schneider, 2015-06-08 11:25:49]

lgtm

https://codereview.chromium.org/1162033005/diff/20001/runtime/vm/compiler_tes...
File runtime/vm/compiler_test.cc (right):

https://codereview.chromium.org/1162033005/diff/20001/runtime/vm/compiler_tes...
runtime/vm/compiler_test.cc:82: //
Isolate::Current()->flags().set_checked(true);
 Why is this commmented out?

https://codereview.chromium.org/1162033005/diff/20001/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

https://codereview.chromium.org/1162033005/diff/20001/runtime/vm/isolate.cc#n...
runtime/vm/isolate.cc:636: flags_(),
flags_(api_flags) and remove .CopyFrom below

https://codereview.chromium.org/1162033005/diff/20001/runtime/vm/isolate.cc#n...
runtime/vm/isolate.cc:1876: isolate_flags_(),
isolate(Isolate::Current()->flags()) and remove ->CopyFrom below.

https://codereview.chromium.org/1162033005/diff/20001/runtime/vm/isolate.cc#n...
runtime/vm/isolate.cc:1916: isolate_flags_(),
isolate_flags_(Isolate::Current()->flags())  and remove ->CopyFrom below.

https://codereview.chromium.org/1162033005/diff/20001/runtime/vm/isolate.h
File runtime/vm/isolate.h (right):

https://codereview.chromium.org/1162033005/diff/20001/runtime/vm/isolate.h#ne...
runtime/vm/isolate.h:401: void CopyFrom(const Flags& orig);
Are these used outside constructors? Otherwise, just create

explicit Flags(const Flags& orig)

explicit Flags(const Dart_IsolateFlags& api_flags)

and use those instead, possibly make CopyFrom private - no need to expose
explicit a public CopyFrom method.

[Ivan Posva, 2015-06-08 11:53:57]

Thanks,
-ivan

https://codereview.chromium.org/1162033005/diff/20001/runtime/vm/compiler_tes...
File runtime/vm/compiler_test.cc (right):

https://codereview.chromium.org/1162033005/diff/20001/runtime/vm/compiler_tes...
runtime/vm/compiler_test.cc:82: //
Isolate::Current()->flags().set_checked(true);
On 2015/06/08 11:25:49, Florian Schneider wrote:
>  Why is this commmented out?

Because it is being enabled after the isolate has already been setup, which is
not a good thing to do.

As discussed I will change the code above to do an explicit check for subtype of
A.