Fix http://dartbug.com/23578:

runtime/vm/compiler_test.cc

Index: runtime/vm/compiler_test.cc
diff --git a/runtime/vm/compiler_test.cc b/runtime/vm/compiler_test.cc
index 1351fbc41a94434f977871637f05a8ccc51adea5..7b6ada791c72afb1ea9234913424168a6b481619 100644
--- a/runtime/vm/compiler_test.cc
+++ b/runtime/vm/compiler_test.cc
@@ -13,8 +13,6 @@
 
 namespace dart {
 
-DECLARE_FLAG(bool, enable_type_checks);
-
 TEST_CASE(CompileScript) {
   const char* kScriptChars =
       "class A {\n"
@@ -81,8 +79,7 @@ TEST_CASE(RegenerateAllocStubs) {
             "  return unOpt();\n"
             "}\n";
 
-  bool old_enable_type_checks = FLAG_enable_type_checks;
-  FLAG_enable_type_checks = true;
+  // Isolate::Current()->flags().set_checked(true);

[Florian Schneider, 2015/06/08 11:25:49]

 Why is this commmented out?

[Ivan Posva, 2015/06/08 11:53:57]

Because it is being enabled after the isolate has already been setup, which is
not a good thing to do.

As discussed I will change the code above to do an explicit check for subtype of
A.

   Dart_Handle lib = TestCase::LoadTestScript(kScriptChars, NULL);
   Dart_Handle result = Dart_Invoke(lib, NewString("main"), 0, NULL);
   EXPECT_VALID(result);
@@ -109,8 +106,6 @@ TEST_CASE(RegenerateAllocStubs) {
   owner.DisableAllocationStub();
   result = Dart_Invoke(lib, NewString("main"), 0, NULL);
   EXPECT_VALID(result);
-
-  FLAG_enable_type_checks = old_enable_type_checks;
 }