Issue 11620004: Removed READ_ONLY constants from IDBTransaction class

Issue 11620004: Removed READ_ONLY constants from IDBTransaction class (Closed)

Created:
8 years ago by Emily Fortuna

Modified:
8 years ago

Reviewers:
sra1, blois

CC:
reviews_dartlang.org, ahe

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Removed READ_ONLY constants from IDBTransaction class BUG= Committed: https://code.google.com/p/dart/source/detail?r=16276

Patch Set 2 : #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -60 lines)			Patch
	M	sdk/lib/html/templates/html/dart2js/impl_IDBDatabase.darttemplate	View	1	1 chunk	+1 line, -30 lines	0 comments	Download
	M	sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart	View	1	2 chunks	+1 line, -30 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sra1

https://chromiumcodereview.appspot.com/11620004/diff/5/sdk/lib/html/templates/html/dart2js/impl_IDBDatabase.darttemplate File sdk/lib/html/templates/html/dart2js/impl_IDBDatabase.darttemplate (right): https://chromiumcodereview.appspot.com/11620004/diff/5/sdk/lib/html/templates/html/dart2js/impl_IDBDatabase.darttemplate#newcode18 sdk/lib/html/templates/html/dart2js/impl_IDBDatabase.darttemplate:18: if (_transaction_fn != null) { remove https://chromiumcodereview.appspot.com/11620004/diff/5/sdk/lib/html/templates/html/dart2js/impl_IDBDatabase.darttemplate#newcode26 sdk/lib/html/templates/html/dart2js/impl_IDBDatabase.darttemplate:26: _transaction_fn ...

8 years ago (2012-12-18 00:56:52 UTC) #3

Emily Fortuna

8 years ago (2012-12-18 18:57:47 UTC) #4

https://chromiumcodereview.appspot.com/11620004/diff/5/sdk/lib/html/templates...
File sdk/lib/html/templates/html/dart2js/impl_IDBDatabase.darttemplate (right):

https://chromiumcodereview.appspot.com/11620004/diff/5/sdk/lib/html/templates...
sdk/lib/html/templates/html/dart2js/impl_IDBDatabase.darttemplate:18: if
(_transaction_fn != null) {
On 2012/12/18 00:56:52, sra1 wrote:
> remove

Done.

https://chromiumcodereview.appspot.com/11620004/diff/5/sdk/lib/html/templates...
sdk/lib/html/templates/html/dart2js/impl_IDBDatabase.darttemplate:26:
_transaction_fn = _transaction_string_mode;
On 2012/12/18 00:56:52, sra1 wrote:
> Since this is the only remaining version of the function, we can get rid of
the
> variable _transaction_fn and call _transaction directly.

Done.

https://chromiumcodereview.appspot.com/11620004/diff/5/sdk/lib/html/templates...
sdk/lib/html/templates/html/dart2js/impl_IDBDatabase.darttemplate:30: static
Transaction _transaction_string_mode($CLASSNAME db, stores, mode) {
On 2012/12/18 00:56:52, sra1 wrote:
> remove

Done.

https://chromiumcodereview.appspot.com/11620004/diff/5/sdk/lib/html/templates...
sdk/lib/html/templates/html/dart2js/impl_IDBDatabase.darttemplate:37: static
bool _hasNumericMode(txn) =>
On 2012/12/18 00:56:52, sra1 wrote:
> remove

Done.

https://chromiumcodereview.appspot.com/11620004/diff/5/sdk/lib/html/templates...
sdk/lib/html/templates/html/dart2js/impl_IDBDatabase.darttemplate:44: var
_transaction_fn;  // Assigned one of the static methods.
On 2012/12/18 00:56:52, sra1 wrote:
> remove

Done.

Expand Messages | Collapse Messages