Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Unified Diff: sdk/lib/html/templates/html/dart2js/impl_IDBDatabase.darttemplate

Issue 11620004: Removed READ_ONLY constants from IDBTransaction class (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/templates/html/dart2js/impl_IDBDatabase.darttemplate
diff --git a/sdk/lib/html/templates/html/dart2js/impl_IDBDatabase.darttemplate b/sdk/lib/html/templates/html/dart2js/impl_IDBDatabase.darttemplate
index d2eee5ad6005e17387c50ba6961ab23f61c41533..5629a9fda62cf0ba9ea27a18e89dd2efb76705df 100644
--- a/sdk/lib/html/templates/html/dart2js/impl_IDBDatabase.darttemplate
+++ b/sdk/lib/html/templates/html/dart2js/impl_IDBDatabase.darttemplate
@@ -15,42 +15,13 @@ class $CLASSNAME$EXTENDS$IMPLEMENTS$NATIVESPEC {
// TODO(sra): Ensure storeName_OR_storeNames is a string or List<String>,
// and copy to JavaScript array if necessary.
- if (_transaction_fn != null) {
- return _transaction_fn(this, storeName_OR_storeNames, mode);
- }
-
// Try and create a transaction with a string mode. Browsers that expect a
// numeric mode tend to convert the string into a number. This fails
// silently, resulting in zero ('readonly').
- var txn = _transaction(storeName_OR_storeNames, mode);
- if (_hasNumericMode(txn)) {
- _transaction_fn = _transaction_numeric_mode;
- txn = _transaction_fn(this, storeName_OR_storeNames, mode);
- } else {
- _transaction_fn = _transaction_string_mode;
- }
- return txn;
- }
-
- static Transaction _transaction_string_mode($CLASSNAME db, stores, mode) {
- return db._transaction(stores, mode);
- }
-
- static Transaction _transaction_numeric_mode($CLASSNAME db, stores, mode) {
- int intMode;
- if (mode == 'readonly') intMode = Transaction.READ_ONLY;
- if (mode == 'readwrite') intMode = Transaction.READ_WRITE;
- return db._transaction(stores, intMode);
+ return _transaction(storeName_OR_storeNames, mode);
}
@JSName('transaction')
Transaction _transaction(stores, mode) native;
- static bool _hasNumericMode(txn) =>
- JS('bool', 'typeof(#.mode) === "number"', txn);
-
$!MEMBERS}
-
-// TODO(sra): This should be a static member of IDBTransaction but dart2js
-// can't handle that. Move it back after dart2js is completely done.
-var _transaction_fn; // Assigned one of the static methods.
« no previous file with comments | « no previous file | sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698