Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1161793002: Revert "dart2js cps: 'is' checks on types with type arguments." (Closed)

Created:
5 years, 6 months ago by asgerf
Modified:
5 years, 6 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "dart2js cps: 'is' checks on types with type arguments." This reverts commit 00c33fb1347fc5c44a324f9503c7c57969e88ca3. TBR=karlklose@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/f0c4e31174996e6259fab283af14c49aa8faf28c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -163 lines) Patch
M pkg/analyzer2dart/test/sexpr_data.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 9 chunks +48 lines, -45 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 2 chunks +11 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 2 chunks +4 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 1 chunk +3 lines, -29 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/glue.dart View 2 chunks +0 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/optimization/pull_into_initializers.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart View 3 chunks +5 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/co19/co19-dart2js.status View 9 chunks +39 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/sexpr_unstringifier.dart View 1 chunk +1 line, -4 lines 0 comments Download
M tests/compiler/dart2js_extra/dart2js_extra.status View 2 chunks +5 lines, -0 lines 0 comments Download
M tests/compiler/dart2js_native/dart2js_native.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/corelib/corelib.status View 4 chunks +16 lines, -6 lines 0 comments Download
M tests/language/language_dart2js.status View 20 chunks +82 lines, -8 lines 0 comments Download
M tests/lib/lib.status View 2 chunks +4 lines, -1 line 0 comments Download
M tests/standalone/standalone.status View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
asgerf
Committed patchset #1 (id:1) manually as f0c4e31174996e6259fab283af14c49aa8faf28c (presubmit successful).
5 years, 6 months ago (2015-05-27 11:54:13 UTC) #1
karlklose
LGTM. What happened?
5 years, 6 months ago (2015-05-27 12:21:25 UTC) #2
asgerf
5 years, 6 months ago (2015-05-27 12:22:55 UTC) #3
Message was sent while issue was closed. 
On 2015/05/27 12:21:25, karlklose wrote:
> LGTM. What happened?

Forgot to run analyzer2dart tests. They are now being skipped and I've
recomitted this CL as-is.

Powered by Google App Engine
This is Rietveld 408576698