Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2849)

Unified Diff: pkg/compiler/lib/src/cps_ir/type_propagation.dart

Issue 1161793002: Revert "dart2js cps: 'is' checks on types with type arguments." (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/cps_ir/type_propagation.dart
diff --git a/pkg/compiler/lib/src/cps_ir/type_propagation.dart b/pkg/compiler/lib/src/cps_ir/type_propagation.dart
index 842d460e100272048de5271cc68f01f3cac6d5e4..2a4307e2e7d01a333240b8505a433a61ccee1fdf 100644
--- a/pkg/compiler/lib/src/cps_ir/type_propagation.dart
+++ b/pkg/compiler/lib/src/cps_ir/type_propagation.dart
@@ -301,8 +301,7 @@ class _TransformingVisitor<T> extends RecursiveVisitor {
void visitTypeOperator(TypeOperator node) {
Continuation cont = node.continuation.definition;
LetPrim letPrim = constifyExpression(node, cont, () {
- node.value.unlink();
- node.typeArguments.forEach((Reference ref) => ref.unlink());
+ node.receiver.unlink();
node.continuation.unlink();
});
@@ -708,10 +707,9 @@ class _TypePropagationVisitor<T> implements Visitor {
if (node.isTypeCast) {
// TODO(jgruber): Add support for `as` casts.
setValues(nonConstant());
- return;
}
- _AbstractValue<T> cell = getValue(node.value.definition);
+ _AbstractValue<T> cell = getValue(node.receiver.definition);
if (cell.isNothing) {
return; // And come back later.
} else if (cell.isConstant && node.type.kind == types.TypeKind.INTERFACE) {
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart ('k') | pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698