Issue 11617004: Fix analyzer errors and warnings for pkg/http.

Issue 11617004: Fix analyzer errors and warnings for pkg/http. (Closed)

Created:
8 years ago by nweiz

Modified:
8 years ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix analyzer errors and warnings for pkg/http. BUG=7458 Committed: https://code.google.com/p/dart/source/detail?r=16238

Patch Set 1 #

Total comments: 4

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -5 lines)			Patch
M	pkg/http/lib/src/client.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	pkg/http/lib/src/streamed_request.dart	View	2 chunks	+7 lines, -4 lines	4 comments	Download
M	pkg/http/test/utils.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

One question, but LGTM. https://codereview.chromium.org/11617004/diff/1/pkg/http/lib/src/streamed_request.dart File pkg/http/lib/src/streamed_request.dart (right): https://codereview.chromium.org/11617004/diff/1/pkg/http/lib/src/streamed_request.dart#newcode29 pkg/http/lib/src/streamed_request.dart:29: final ListOutputStream _outputStream; Why did ...

8 years ago (2012-12-17 23:55:15 UTC) #2

nweiz

https://codereview.chromium.org/11617004/diff/1/pkg/http/lib/src/streamed_request.dart File pkg/http/lib/src/streamed_request.dart (right): https://codereview.chromium.org/11617004/diff/1/pkg/http/lib/src/streamed_request.dart#newcode29 pkg/http/lib/src/streamed_request.dart:29: final ListOutputStream _outputStream; On 2012/12/17 23:55:15, Bob Nystrom wrote: ...

8 years ago (2012-12-18 00:25:32 UTC) #3

Bob Nystrom

8 years ago (2012-12-18 00:26:25 UTC) #4

nweiz

8 years ago (2012-12-18 19:21:52 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/11617004/diff/1/pkg/http/lib/src/streamed_req...
File pkg/http/lib/src/streamed_request.dart (right):

https://codereview.chromium.org/11617004/diff/1/pkg/http/lib/src/streamed_req...
pkg/http/lib/src/streamed_request.dart:29: final ListOutputStream _outputStream;
On 2012/12/18 00:26:25, Bob Nystrom wrote:
> On 2012/12/18 00:25:32, nweiz wrote:
> > On 2012/12/17 23:55:15, Bob Nystrom wrote:
> > > Why did you have to make this change?
> > 
> > Because onData and read() (referred to in the constructor) are only methods
on
> > ListOutputStream, not on OutputStream.
> 
> If those are only in the ctor, how about just making a local variable or using
> "as"?

I'll do that in a separate CL.

Expand Messages | Collapse Messages