Fix analyzer errors and warnings for pkg/http.

pkg/http/lib/src/streamed_request.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library streamed_request;
 
 import 'dart:io';
 import 'dart:uri';
 
 import 'base_request.dart';
 
 /// An HTTP request where the request body is sent asynchronously after the
 /// connection has been established and the headers have been sent.
 ///
 /// When the request is sent via [BaseClient.send], only the headers and
 /// whatever data has already been written to [StreamedRequest.stream] will be
 /// sent immediately. More data will be sent as soon as it's written to
 /// [StreamedRequest.stream], and when the stream is closed the request will
 /// end.
 class StreamedRequest extends BaseRequest {
   /// The stream to which to write data that will be sent as the request body.
   /// This may be safely written to before the request is sent; the data will be
   /// buffered.
   ///
   /// Closing this signals the end of the request.
-  final OutputStream stream;
+  OutputStream get stream => _outputStream;
+
+  /// [stream], stored as a [ListOutputStream].
+  final ListOutputStream _outputStream;

[Bob Nystrom, 2012/12/17 23:55:15]

Why did you have to make this change?

[nweiz, 2012/12/18 00:25:32]

Because onData and read() (referred to in the constructor) are only methods on
ListOutputStream, not on OutputStream.

[Bob Nystrom, 2012/12/18 00:26:25]

If those are only in the ctor, how about just making a local variable or using
"as"?

[nweiz, 2012/12/18 19:21:52]

I'll do that in a separate CL.

 
   /// The stream from which the [BaseClient] will read the data in [stream] once
   /// the request has been finalized.
   final ListInputStream _inputStream;
 
   /// Creates a new streaming request.
   StreamedRequest(String method, Uri url)
     : super(method, url),
-      stream = new ListOutputStream(),
+      _outputStream = new ListOutputStream(),
       _inputStream = new ListInputStream() {
     // TODO(nweiz): pipe errors from the output stream to the input stream once
     // issue 3657 is fixed
-    stream.onData = () => _inputStream.write(stream.read());
-    stream.onClosed = _inputStream.markEndOfStream;
+    _outputStream.onData = () => _inputStream.write(_outputStream.read());
+    _outputStream.onClosed = _inputStream.markEndOfStream;
   }
 
   /// Freezes all mutable fields other than [stream] and returns an [InputStream]
   /// that emits the data being written to [stream].
   InputStream finalize() {
     super.finalize();
     return _inputStream;
   }
 }