Issue 1161343002: Issue 23409. Don't set 'propagatedType' in (vs. after) 'name is Type'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1161343002: Issue 23409. Don't set 'propagatedType' in (vs. after) 'name is Type'. (Closed)

Created:
5 years, 6 months ago by scheglov

Modified:
5 years, 6 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Issue 23409. Don't set 'propagatedType' in (vs. after) 'name is Type'. This fixes the corresponding 'Extract Method' issue. R=brianwilkerson@google.com BUG=https://code.google.com/p/dart/issues/detail?id=23409 Committed: https://github.com/dart-lang/sdk/commit/f1d4ef9164f42a917ed73af4d78171497f479601

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+64 lines, -15 lines)			Patch
M	pkg/analysis_server/pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/test/services/refactoring/extract_method_test.dart	View	1 chunk	+33 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/resolver.dart	View	4 chunks	+8 lines, -6 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/static_type_analyzer.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer/pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer/test/generated/resolver_test.dart	View	1 chunk	+20 lines, -6 lines	0 comments	Download

Total messages: 4 (0 generated)

Brian Wilkerson

Although, we need to remember to publish analyzer after this is committed so that analysis ...

5 years, 6 months ago (2015-06-01 19:39:30 UTC) #3

scheglov

5 years, 6 months ago (2015-06-01 19:40:36 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f1d4ef9164f42a917ed73af4d78171497f479601 (presubmit successful).