pkg/analyzer/lib/src/generated/static_type_analyzer.dart - Issue 1161343002: Issue 23409. Don't set 'propagatedType' in (vs. after) 'name is Type'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/generated/static_type_analyzer.dart

Issue 1161343002: Issue 23409. Don't set 'propagatedType' in (vs. after) 'name is Type'. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/analyzer/lib/src/generated/static_type_analyzer.dart

diff --git a/pkg/analyzer/lib/src/generated/static_type_analyzer.dart b/pkg/analyzer/lib/src/generated/static_type_analyzer.dart

index f69d2a4912f94be8002972ef337d7ccb870622be..d091b2a8b108f2fac3f3e320e8b9cc6fa7984781 100644

--- a/pkg/analyzer/lib/src/generated/static_type_analyzer.dart

+++ b/pkg/analyzer/lib/src/generated/static_type_analyzer.dart

@@ -156,7 +156,7 @@ class StaticTypeAnalyzer extends SimpleAstVisitor<Object> {

_resolver.recordPropagatedTypeIfBetter(node, propagatedType);

overrideType = propagatedType;

}

- _resolver.overrideExpression(node.leftHandSide, overrideType, true);

+ _resolver.overrideExpression(node.leftHandSide, overrideType, true, true);

} else if (operator == sc.TokenType.QUESTION_QUESTION_EQ) {

// The static type of a compound assignment using ??= is the least upper

// bound of the static types of the LHS and RHS.

« no previous file with comments | « pkg/analyzer/lib/src/generated/resolver.dart ('k') | pkg/analyzer/pubspec.yaml » ('j') | no next file with comments »