Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1159153004: Don't run old implementation tests with 'useTaskModel == true'. (Closed)

Created:
5 years, 6 months ago by scheglov
Modified:
5 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't run old implementation tests with 'useTaskModel == true'. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/b916cbffa467e8671cacd6b69d469dc2386d29c6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -26 lines) Patch
M pkg/analyzer/test/generated/engine_test.dart View 1 chunk +27 lines, -23 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 1 chunk +9 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 6 months ago (2015-06-08 17:33:00 UTC) #1
Brian Wilkerson
LGTM
5 years, 6 months ago (2015-06-08 18:00:21 UTC) #2
scheglov
5 years, 6 months ago (2015-06-08 18:03:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b916cbffa467e8671cacd6b69d469dc2386d29c6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698