Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: pkg/analyzer/test/generated/engine_test.dart

Issue 1159153004: Don't run old implementation tests with 'useTaskModel == true'. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/test/generated/resolver_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/generated/engine_test.dart
diff --git a/pkg/analyzer/test/generated/engine_test.dart b/pkg/analyzer/test/generated/engine_test.dart
index 85ffcabcac4bec70e4c5da07672c48032324c323..b4c28f487b9c3ccecde36f5a9403bbb5f84a4c9e 100644
--- a/pkg/analyzer/test/generated/engine_test.dart
+++ b/pkg/analyzer/test/generated/engine_test.dart
@@ -47,30 +47,34 @@ import 'test_support.dart';
main() {
groupSep = ' | ';
- runReflectiveTests(AnalysisCacheTest);
- runReflectiveTests(AnalysisContextImplTest);
- runReflectiveTests(AnalysisTaskTest);
- runReflectiveTests(AnalysisOptionsImplTest);
- runReflectiveTests(DartEntryTest);
- runReflectiveTests(GenerateDartErrorsTaskTest);
- runReflectiveTests(GenerateDartHintsTaskTest);
- runReflectiveTests(GenerateDartLintsTaskTest);
- runReflectiveTests(GetContentTaskTest);
- runReflectiveTests(HtmlEntryTest);
- runReflectiveTests(IncrementalAnalysisCacheTest);
- runReflectiveTests(IncrementalAnalysisTaskTest);
- runReflectiveTests(LintGeneratorTest);
- runReflectiveTests(ParseDartTaskTest);
- runReflectiveTests(ParseHtmlTaskTest);
- runReflectiveTests(PartitionManagerTest);
- runReflectiveTests(ResolveDartLibraryTaskTest);
- runReflectiveTests(ResolveDartUnitTaskTest);
- runReflectiveTests(ResolveHtmlTaskTest);
- runReflectiveTests(ScanDartTaskTest);
- runReflectiveTests(SdkCachePartitionTest);
+ // Tests for the classes used in both old and new analysis implementations.
runReflectiveTests(SourcesChangedEventTest);
- runReflectiveTests(UniversalCachePartitionTest);
- runReflectiveTests(WorkManagerTest);
+ // Tests for the classes used in the old analysis implementation.
+ if (!AnalysisEngine.instance.useTaskModel) {
+ runReflectiveTests(AnalysisCacheTest);
+ runReflectiveTests(AnalysisContextImplTest);
+ runReflectiveTests(AnalysisTaskTest);
+ runReflectiveTests(AnalysisOptionsImplTest);
+ runReflectiveTests(DartEntryTest);
+ runReflectiveTests(GenerateDartErrorsTaskTest);
+ runReflectiveTests(GenerateDartHintsTaskTest);
+ runReflectiveTests(GenerateDartLintsTaskTest);
+ runReflectiveTests(GetContentTaskTest);
+ runReflectiveTests(HtmlEntryTest);
+ runReflectiveTests(IncrementalAnalysisCacheTest);
+ runReflectiveTests(IncrementalAnalysisTaskTest);
+ runReflectiveTests(LintGeneratorTest);
+ runReflectiveTests(ParseDartTaskTest);
+ runReflectiveTests(ParseHtmlTaskTest);
+ runReflectiveTests(PartitionManagerTest);
+ runReflectiveTests(ResolveDartLibraryTaskTest);
+ runReflectiveTests(ResolveDartUnitTaskTest);
+ runReflectiveTests(ResolveHtmlTaskTest);
+ runReflectiveTests(ScanDartTaskTest);
+ runReflectiveTests(SdkCachePartitionTest);
+ runReflectiveTests(UniversalCachePartitionTest);
+ runReflectiveTests(WorkManagerTest);
+ }
}
@reflectiveTest
« no previous file with comments | « no previous file | pkg/analyzer/test/generated/resolver_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698