Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1158413003: remove keyword suggestions in constructor names and prefixed expressions (Closed)

Created:
5 years, 6 months ago by danrubel
Modified:
5 years, 6 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

remove keyword suggestions in constructor names and prefixed expressions BUG= R=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/ecf44e960d759e31fe6f5138704536ace9ec1340

Patch Set 1 #

Total comments: 3

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -0 lines) Patch
M pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart View 1 chunk +18 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/keyword_contributor_test.dart View 2 chunks +48 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
danrubel
5 years, 6 months ago (2015-05-29 15:57:00 UTC) #2
Paul Berry
lgtm https://codereview.chromium.org/1158413003/diff/1/pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart File pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart (right): https://codereview.chromium.org/1158413003/diff/1/pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart#newcode153 pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart:153: visitInstanceCreationExpression(InstanceCreationExpression node) { Do similar cases need to ...
5 years, 6 months ago (2015-05-29 16:00:48 UTC) #3
danrubel
https://codereview.chromium.org/1158413003/diff/1/pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart File pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart (right): https://codereview.chromium.org/1158413003/diff/1/pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart#newcode153 pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart:153: visitInstanceCreationExpression(InstanceCreationExpression node) { On 2015/05/29 16:00:47, Paul Berry wrote: ...
5 years, 6 months ago (2015-05-29 17:26:41 UTC) #4
danrubel
Committed patchset #2 (id:20001) manually as ecf44e960d759e31fe6f5138704536ace9ec1340 (presubmit successful).
5 years, 6 months ago (2015-05-29 17:28:40 UTC) #5
danrubel
5 years, 6 months ago (2015-06-06 15:32:20 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1158413003/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart
(right):

https://codereview.chromium.org/1158413003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart:153:
visitInstanceCreationExpression(InstanceCreationExpression node) {
On 2015/05/29 17:26:41, danrubel wrote:
> On 2015/05/29 16:00:47, Paul Berry wrote:
> > Do similar cases need to be added for visitPropertyAccess and
> > visitPrefixedExpression?
> 
> Good point. Will address in subsequent CL.

https://codereview.chromium.org/1151493004/

Powered by Google App Engine
This is Rietveld 408576698