remove keyword suggestions in constructor names and prefixed expressions

pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.completion.contributor.dart.keyword;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/protocol.dart';
 import 'package:analysis_server/src/services/completion/dart_completion_manager.dart';
@@ skipping 132 matching lines @@
       _addCompilationUnitKeywords();
     }
   }
 
   @override
   visitExpression(Expression node) {
     _addExpressionKeywords(node);
   }
 
   @override
+  visitInstanceCreationExpression(InstanceCreationExpression node) {

[Paul Berry, 2015/05/29 16:00:47]

Do similar cases need to be added for visitPropertyAccess and
visitPrefixedExpression?

[danrubel, 2015/05/29 17:26:41]

Good point. Will address in subsequent CL.

[danrubel, 2015/06/06 15:32:20]

https://codereview.chromium.org/1151493004/

+    if (entity == node.constructorName) {
+      // no keywords in 'new ^' expression
+    } else {
+      super.visitInstanceCreationExpression(node);
+    }
+  }
+
+  @override
+  visitMethodInvocation(MethodInvocation node) {
+    if (entity == node.methodName) {
+      // no keywords in '.' expression
+    } else {
+      super.visitMethodInvocation(node);
+    }
+  }
+
+  @override
   visitExpressionFunctionBody(ExpressionFunctionBody node) {
     if (entity == node.expression) {
       _addExpressionKeywords(node);
     }
   }
 
   @override
   visitFormalParameterList(FormalParameterList node) {
     AstNode constructorDecl =
         node.getAncestor((p) => p is ConstructorDeclaration);
@@ skipping 227 matching lines @@
         return false;
       }
       AstNode parent = body.parent;
       if (parent is ConstructorDeclaration || parent is MethodDeclaration) {
         return true;
       }
       node = parent;
     }
   }
 }