Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 1158103002: Use words! closureFunc -> function, closureCtxt -> context. (Closed)

Created:
5 years, 7 months ago by rmacnak
Modified:
5 years, 7 months ago
Reviewers:
turnidge, Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use words! closureFunc -> function, closureCtxt -> context. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/69c50f7294f3110aa068da4f8c5b3674f41b3b49

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -25 lines) Patch
M runtime/observatory/lib/src/elements/instance_ref.html View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/instance_view.html View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 4 chunks +6 lines, -6 lines 0 comments Download
M runtime/observatory/tests/service/contexts_test.dart View 4 chunks +12 lines, -12 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rmacnak
5 years, 7 months ago (2015-05-26 23:02:26 UTC) #2
Cutch
lgtm
5 years, 7 months ago (2015-05-26 23:05:05 UTC) #3
rmacnak
5 years, 7 months ago (2015-05-26 23:08:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
69c50f7294f3110aa068da4f8c5b3674f41b3b49 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698