Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Side by Side Diff: runtime/vm/object.cc

Issue 1158103002: Use words! closureFunc -> function, closureCtxt -> context. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/observatory/tests/service/contexts_test.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/object.h" 5 #include "vm/object.h"
6 6
7 #include "include/dart_api.h" 7 #include "include/dart_api.h"
8 #include "platform/assert.h" 8 #include "platform/assert.h"
9 #include "vm/assembler.h" 9 #include "vm/assembler.h"
10 #include "vm/cpu.h" 10 #include "vm/cpu.h"
(...skipping 14126 matching lines...) Expand 10 before | Expand all | Expand 10 after
14137 jsobj.AddProperty("type", "Sentinel"); 14137 jsobj.AddProperty("type", "Sentinel");
14138 jsobj.AddProperty("id", "objects/being-initialized"); 14138 jsobj.AddProperty("id", "objects/being-initialized");
14139 jsobj.AddProperty("valueAsString", "<being initialized>"); 14139 jsobj.AddProperty("valueAsString", "<being initialized>");
14140 return; 14140 return;
14141 } 14141 }
14142 14142
14143 AddTypeProperties(&jsobj, "Instance", JSONType(), ref); 14143 AddTypeProperties(&jsobj, "Instance", JSONType(), ref);
14144 PrintSharedInstanceJSON(&jsobj, ref); 14144 PrintSharedInstanceJSON(&jsobj, ref);
14145 jsobj.AddServiceId("id", *this); 14145 jsobj.AddServiceId("id", *this);
14146 if (IsClosure()) { 14146 if (IsClosure()) {
14147 const Function& closureFunc = Function::Handle(Closure::function(*this)); 14147 jsobj.AddProperty("function", Function::Handle(Closure::function(*this)));
14148 jsobj.AddProperty("closureFunc", closureFunc); 14148 jsobj.AddProperty("context", Context::Handle(Closure::context(*this)));
14149 const Context& closureCtxt = Context::Handle(Closure::context(*this));
14150 jsobj.AddProperty("closureCtxt", closureCtxt);
14151 } 14149 }
14152 if (ref) { 14150 if (ref) {
14153 return; 14151 return;
14154 } 14152 }
14155 } 14153 }
14156 14154
14157 14155
14158 bool AbstractType::IsResolved() const { 14156 bool AbstractType::IsResolved() const {
14159 // AbstractType is an abstract class. 14157 // AbstractType is an abstract class.
14160 UNREACHABLE(); 14158 UNREACHABLE();
(...skipping 6640 matching lines...) Expand 10 before | Expand all | Expand 10 after
20801 return tag_label.ToCString(); 20799 return tag_label.ToCString();
20802 } 20800 }
20803 20801
20804 20802
20805 void UserTag::PrintJSONImpl(JSONStream* stream, bool ref) const { 20803 void UserTag::PrintJSONImpl(JSONStream* stream, bool ref) const {
20806 Instance::PrintJSONImpl(stream, ref); 20804 Instance::PrintJSONImpl(stream, ref);
20807 } 20805 }
20808 20806
20809 20807
20810 } // namespace dart 20808 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/observatory/tests/service/contexts_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698