Compute more SendStructures on ResolverVisitor.

Compute more SendStructures on ResolverVisitor.

BUG=
R=karlklose@google.com

Committed: https://github.com/dart-lang/sdk/commit/76728304e95bdd65e4403879ef9e32d98600df52

[Johnni Winther, 2015-05-28 17:08:57]

johnniwinther@google.com changed reviewers:
+ karlklose@google.com

[karlklose, 2015-05-29 11:12:14]

LGTM.

https://codereview.chromium.org/1157333003/diff/1/pkg/compiler/lib/src/resolu...
File pkg/compiler/lib/src/resolution/members.dart (right):

https://codereview.chromium.org/1157333003/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/members.dart:1112: // TODO(johnniwinther):
Remove this when all information goes through the
Maybe extract setSelector/registerDynamicInvocation pairs into a helper so that
you only need to add the TODO there.

https://codereview.chromium.org/1157333003/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/members.dart:1267: if (node.isConditional) {
Should this be an internalError?

https://codereview.chromium.org/1157333003/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/members.dart:1379: /// Handle an unqualified
[Send], that is where the receiver is null, like
Make clear that the receiver Node is null, not the value.

https://codereview.chromium.org/1157333003/diff/1/pkg/compiler/lib/src/resolu...
File pkg/compiler/lib/src/resolution/send_resolver.dart (right):

https://codereview.chromium.org/1157333003/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/send_resolver.dart:279: return
internalError(node, "Unexpected binary $kind.");
Move 'return internalError' after the switch?

[Johnni Winther, 2015-05-29 12:47:54]

https://codereview.chromium.org/1157333003/diff/1/pkg/compiler/lib/src/resolu...
File pkg/compiler/lib/src/resolution/members.dart (right):

https://codereview.chromium.org/1157333003/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/members.dart:1112: // TODO(johnniwinther):
Remove this when all information goes through the
On 2015/05/29 11:12:14, karlklose wrote:
> Maybe extract setSelector/registerDynamicInvocation pairs into a helper so
that
> you only need to add the TODO there.

The two are not always paired :(

https://codereview.chromium.org/1157333003/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/members.dart:1267: if (node.isConditional) {
On 2015/05/29 11:12:14, karlklose wrote:
> Should this be an internalError?

Removed.

https://codereview.chromium.org/1157333003/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/members.dart:1379: /// Handle an unqualified
[Send], that is where the receiver is null, like
On 2015/05/29 11:12:14, karlklose wrote:
> Make clear that the receiver Node is null, not the value.

Good call!

https://codereview.chromium.org/1157333003/diff/1/pkg/compiler/lib/src/resolu...
File pkg/compiler/lib/src/resolution/send_resolver.dart (right):

https://codereview.chromium.org/1157333003/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/send_resolver.dart:279: return
internalError(node, "Unexpected binary $kind.");
On 2015/05/29 11:12:14, karlklose wrote:
> Move 'return internalError' after the switch?

We still need to index in compounds.

[Johnni Winther, 2015-05-29 13:26:35]

Committed patchset #4 (id:60001) manually as
76728304e95bdd65e4403879ef9e32d98600df52 (presubmit successful).

[Johnni Winther, 2015-05-29 13:26:44]

Last patch TBR