Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Unified Diff: tests/compiler/dart2js/semantic_visitor_test.dart

Issue 1157333003: Compute more SendStructures on ResolverVisitor. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Check for explicit this property access. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/compiler/dart2js/resolver_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/semantic_visitor_test.dart
diff --git a/tests/compiler/dart2js/semantic_visitor_test.dart b/tests/compiler/dart2js/semantic_visitor_test.dart
index ffb742a871e42bc0d3cadf9d27ef52c98385d47c..1a0ddc2745419006af359dfc560be994db3ed4b2 100644
--- a/tests/compiler/dart2js/semantic_visitor_test.dart
+++ b/tests/compiler/dart2js/semantic_visitor_test.dart
@@ -1234,7 +1234,6 @@ const Map<String, List<Test>> SEND_TESTS = const {
''',
const Visit(VisitKind.VISIT_SUPER_GETTER_GET,
element: 'getter(B#o)')),
- // TODO(johnniwinther): Expect [VISIT_SUPER_SETTER_GET] instead.
const Test.clazz(
'''
class B {
@@ -1244,7 +1243,8 @@ const Map<String, List<Test>> SEND_TESTS = const {
m() => super.o;
}
''',
- const Visit(VisitKind.VISIT_UNRESOLVED_SUPER_GET)),
+ const Visit(VisitKind.VISIT_SUPER_SETTER_GET,
+ element: 'setter(B#o)')),
// TODO(johnniwinther): Expect [VISIT_SUPER_GETTER_SET] instead.
const Test.clazz(
'''
@@ -1282,7 +1282,6 @@ const Map<String, List<Test>> SEND_TESTS = const {
const Visit(VisitKind.VISIT_SUPER_GETTER_INVOKE,
element: 'getter(B#o)',
arguments: '(null,42)')),
- // TODO(johnniwinther): Expect [VISIT_SUPER_SETTER_INVOKE] instead.
const Test.clazz(
'''
class B {
@@ -1292,7 +1291,8 @@ const Map<String, List<Test>> SEND_TESTS = const {
m() { super.o(null, 42); }
}
''',
- const Visit(VisitKind.VISIT_UNRESOLVED_SUPER_INVOKE,
+ const Visit(VisitKind.VISIT_SUPER_SETTER_INVOKE,
+ element: 'setter(B#o)',
arguments: '(null,42)')),
],
'Super methods': const [
@@ -4305,8 +4305,6 @@ const List<VisitKind> UNTESTABLE_KINDS = const <VisitKind>[
VisitKind.VISIT_TOP_LEVEL_FUNCTION_SET,
VisitKind.VISIT_FINAL_SUPER_FIELD_SET,
VisitKind.VISIT_SUPER_GETTER_SET,
- VisitKind.VISIT_SUPER_SETTER_GET,
- VisitKind.VISIT_SUPER_SETTER_INVOKE,
VisitKind.VISIT_SUPER_METHOD_SET,
];
« no previous file with comments | « tests/compiler/dart2js/resolver_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698