Issue 11572009: Support for typedef in checked mode.

Issue 11572009: Support for typedef in checked mode. (Closed)

Created:
8 years ago by ngeoffray

Modified:
8 years ago

Reviewers:
karlklose, kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Support for typedef in checked mode. Committed: https://code.google.com/p/dart/source/detail?r=16154

Patch Set 3 : #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -37 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/js_backend/backend.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart	View	1	5 chunks	+22 lines, -8 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/codegen.dart	View	1	2 chunks	+11 lines, -0 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View	1 2	5 chunks	+21 lines, -27 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
A	tests/language/null_typedef_test.dart	View	1 2	1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

I incorporated Karl's change: https://codereview.chromium.org/11571004/. PTAL.

8 years ago (2012-12-13 17:00:36 UTC) #4

kasperl

LGTM. https://codereview.chromium.org/11572009/diff/3002/tests/co19/co19-dart2js.status File tests/co19/co19-dart2js.status (right): https://codereview.chromium.org/11572009/diff/3002/tests/co19/co19-dart2js.status#newcode554 tests/co19/co19-dart2js.status:554: Language/14_Types/4_Interface_Types_A12_t16 :Fail # http://dartbug.com/5020 :Fail -> : Fail

8 years ago (2012-12-14 08:54:43 UTC) #5

ngeoffray

Thanks Kasper https://codereview.chromium.org/11572009/diff/3002/tests/co19/co19-dart2js.status File tests/co19/co19-dart2js.status (right): https://codereview.chromium.org/11572009/diff/3002/tests/co19/co19-dart2js.status#newcode554 tests/co19/co19-dart2js.status:554: Language/14_Types/4_Interface_Types_A12_t16 :Fail # http://dartbug.com/5020 On 2012/12/14 08:54:43, ...

8 years ago (2012-12-14 08:59:33 UTC) #6

ngeoffray

8 years ago (2012-12-14 09:01:35 UTC) #7

Message was sent while issue was closed.

https://codereview.chromium.org/11572009/diff/3002/tests/co19/co19-dart2js.st...
File tests/co19/co19-dart2js.status (right):

https://codereview.chromium.org/11572009/diff/3002/tests/co19/co19-dart2js.st...
tests/co19/co19-dart2js.status:554: Language/14_Types/4_Interface_Types_A12_t16
:Fail # http://dartbug.com/5020
On 2012/12/14 08:54:43, kasperl wrote:
>  :Fail -> : Fail

Done.

Expand Messages | Collapse Messages