Add TypedData instance kinds.

Add TypedData instance kinds.

R=johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/304382c1b42f13ccb91d03a8691a2faff7511d0b

[rmacnak, 2015-06-05 20:32:34]

rmacnak@google.com changed reviewers:
+ johnmccutchan@google.com

[rmacnak, 2015-06-05 20:32:35]

https://codereview.chromium.org/1157003003/diff/20001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/instance_ref.html (right):

https://codereview.chromium.org/1157003003/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/instance_ref.html:105: <div
class="memberValue">{{ ref.typedElements[index] }}</div>
This displays floating points that happen to be integers without a decimal
point, which is misleading.

https://codereview.chromium.org/1157003003/diff/20001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/1157003003/diff/20001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:20113: jsobj.AddProperty("elementType", ElementTypeName());
This feels a bit leaky.

https://codereview.chromium.org/1157003003/diff/20001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:20123: jsarr.AddValue(byte);
base64 would be denser, but is less convenient to reconstruct on the client.

[Cutch, 2015-06-05 21:00:30]

https://codereview.chromium.org/1157003003/diff/20001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/instance_ref.html (right):

https://codereview.chromium.org/1157003003/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/instance_ref.html:105: <div
class="memberValue">{{ ref.typedElements[index] }}</div>
On 2015/06/05 20:32:35, rmacnak wrote:
> This displays floating points that happen to be integers without a decimal
> point, which is misleading.

Is that a problem with our double.toString()

https://codereview.chromium.org/1157003003/diff/20001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/1157003003/diff/20001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:20113: jsobj.AddProperty("elementType", ElementTypeName());
On 2015/06/05 20:32:35, rmacnak wrote:
> This feels a bit leaky.

Let's drop elementType and use use the real list type as "kind", e.g. Int8Array
(but we should probably use Int8List).

https://codereview.chromium.org/1157003003/diff/20001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:20123: jsarr.AddValue(byte);
On 2015/06/05 20:32:35, rmacnak wrote:
> base64 would be denser, but is less convenient to reconstruct on the client.

We should use base64.

[rmacnak, 2015-06-08 22:12:03]

https://codereview.chromium.org/1157003003/diff/20001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/instance_ref.html (right):

https://codereview.chromium.org/1157003003/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/instance_ref.html:105: <div
class="memberValue">{{ ref.typedElements[index] }}</div>
On 2015/06/05 21:00:29, Cutch wrote:
> On 2015/06/05 20:32:35, rmacnak wrote:
> > This displays floating points that happen to be integers without a decimal
> > point, which is misleading.
> 
> Is that a problem with our double.toString()

Actually seems to be JS's toString. As written this shows [object dartobject]
for the vector lists, it seems to toString happened after an interop call. Added
toString here and vectors print as expected.

https://codereview.chromium.org/1157003003/diff/20001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/1157003003/diff/20001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:20113: jsobj.AddProperty("elementType", ElementTypeName());
On 2015/06/05 21:00:29, Cutch wrote:
> On 2015/06/05 20:32:35, rmacnak wrote:
> > This feels a bit leaky.
> 
> Let's drop elementType and use use the real list type as "kind", e.g.
Int8Array
> (but we should probably use Int8List).

Using UserVisibleName

https://codereview.chromium.org/1157003003/diff/20001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:20123: jsarr.AddValue(byte);
On 2015/06/05 21:00:29, Cutch wrote:
> On 2015/06/05 20:32:35, rmacnak wrote:
> > base64 would be denser, but is less convenient to reconstruct on the client.
> 
> We should use base64.

Done.

[Cutch, 2015-06-08 23:10:19]

LGTM with suggestions

https://codereview.chromium.org/1157003003/diff/80001/runtime/observatory/lib...
File runtime/observatory/lib/src/service/object.dart (right):

https://codereview.chromium.org/1157003003/diff/80001/runtime/observatory/lib...
runtime/observatory/lib/src/service/object.dart:1848: const _decodeTable =
Move this to lib/base64.dart

https://codereview.chromium.org/1157003003/diff/80001/runtime/observatory/lib...
runtime/observatory/lib/src/service/object.dart:1878: var result = new
Uint8List(s.length ~/ 4 * 3 - odd_bits);
var decodedByteLength = ((s.length ~/ 4) * 3) - odd_bits
var result = new Uint8List(decodedByteLength);

https://codereview.chromium.org/1157003003/diff/80001/runtime/observatory/lib...
runtime/observatory/lib/src/service/object.dart:1906: return result;
assert(j == decodedByteLength);
return result;

https://codereview.chromium.org/1157003003/diff/80001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/1157003003/diff/80001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:20120: const String& user_name =
String::Handle(cls.UserVisibleName());
const String& kind = String::Handle(cls.UserVisibleName()); ?

[rmacnak, 2015-06-09 00:29:47]

https://codereview.chromium.org/1157003003/diff/80001/runtime/observatory/lib...
File runtime/observatory/lib/src/service/object.dart (right):

https://codereview.chromium.org/1157003003/diff/80001/runtime/observatory/lib...
runtime/observatory/lib/src/service/object.dart:1848: const _decodeTable =
On 2015/06/08 23:10:19, Cutch wrote:
> Move this to lib/base64.dart

Done.

https://codereview.chromium.org/1157003003/diff/80001/runtime/observatory/lib...
runtime/observatory/lib/src/service/object.dart:1878: var result = new
Uint8List(s.length ~/ 4 * 3 - odd_bits);
On 2015/06/08 23:10:19, Cutch wrote:
> var decodedByteLength = ((s.length ~/ 4) * 3) - odd_bits
> var result = new Uint8List(decodedByteLength);

Done.

https://codereview.chromium.org/1157003003/diff/80001/runtime/observatory/lib...
runtime/observatory/lib/src/service/object.dart:1906: return result;
On 2015/06/08 23:10:19, Cutch wrote:
> assert(j == decodedByteLength);
> return result;

Done.

[rmacnak, 2015-06-09 00:30:17]

Committed patchset #6 (id:100001) manually as
304382c1b42f13ccb91d03a8691a2faff7511d0b (presubmit successful).