Add TypedData instance kinds.

runtime/vm/object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/cpu.h"
@@ skipping 20087 matching lines @@
   return array.raw();
 }
 
 
 const char* TypedData::ToCString() const {
   return "TypedData";
 }
 
 
 void TypedData::PrintJSONImpl(JSONStream* stream, bool ref) const {
-  Instance::PrintJSONImpl(stream, ref);
+  JSONObject jsobj(stream);
+  PrintSharedInstanceJSON(&jsobj, ref);
+  jsobj.AddProperty("kind", "TypedData");
+  jsobj.AddServiceId(*this);
+  jsobj.AddProperty("length", Length());
+  jsobj.AddProperty("elementType", ElementTypeName());

[rmacnak, 2015/06/05 20:32:35]

This feels a bit leaky.

[Cutch, 2015/06/05 21:00:29]

Let's drop elementType and use use the real list type as "kind", e.g. Int8Array
(but we should probably use Int8List).

[rmacnak, 2015/06/08 22:12:03]

Using UserVisibleName

+  if (ref) {
+    return;
+  }
+
+  {
+    JSONArray jsarr(&jsobj, "bytes");
+    for (intptr_t index = 0; index < LengthInBytes(); index++) {
+      NoSafepointScope no_safepoint;
+      uint8_t byte = *reinterpret_cast<uint8_t*>(DataAddr(index));
+      jsarr.AddValue(byte);

[rmacnak, 2015/06/05 20:32:35]

base64 would be denser, but is less convenient to reconstruct on the client.

[Cutch, 2015/06/05 21:00:29]

We should use base64.

[rmacnak, 2015/06/08 22:12:03]

Done.

+    }
+  }
 }
 
 
 FinalizablePersistentHandle* ExternalTypedData::AddFinalizer(
     void* peer, Dart_WeakPersistentHandleFinalizer callback) const {
   return dart::AddFinalizer(*this, peer, callback);
 }
 
 
 RawExternalTypedData* ExternalTypedData::New(intptr_t class_id,
@@ skipping 14 matching lines @@
 }
 
 
 const char* ExternalTypedData::ToCString() const {
   return "ExternalTypedData";
 }
 
 
 void ExternalTypedData::PrintJSONImpl(JSONStream* stream,
                                       bool ref) const {
-  Instance::PrintJSONImpl(stream, ref);
+  JSONObject jsobj(stream);
+  PrintSharedInstanceJSON(&jsobj, ref);
+  jsobj.AddProperty("kind", "TypedData");
+  jsobj.AddServiceId(*this);
+  jsobj.AddProperty("length", Length());
+  jsobj.AddProperty("elementType", ElementTypeName());
+  if (ref) {
+    return;
+  }
+
+  {
+    JSONArray jsarr(&jsobj, "bytes");
+    for (intptr_t index = 0; index < LengthInBytes(); index++) {
+      NoSafepointScope no_safepoint;
+      uint8_t byte = *reinterpret_cast<uint8_t*>(DataAddr(index));
+      jsarr.AddValue(byte);
+    }
+  }
 }
 
 
 RawCapability* Capability::New(uint64_t id, Heap::Space space) {
   Capability& result = Capability::Handle();
   {
     RawObject* raw = Object::Allocate(Capability::kClassId,
                                       Capability::InstanceSize(),
                                       space);
     NoSafepointScope no_safepoint;
@@ skipping 656 matching lines @@
   return tag_label.ToCString();
 }
 
 
 void UserTag::PrintJSONImpl(JSONStream* stream, bool ref) const {
   Instance::PrintJSONImpl(stream, ref);
 }
 
 
 }  // namespace dart