Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11570005: Remove old #import, #source, and #library syntax from tests/standalone. (Closed)

Created:
8 years ago by Bill Hesse
Modified:
8 years ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove old #import, #source, and #library syntax from tests/standalone. BUG=dart:7066 Committed: https://code.google.com/p/dart/source/detail?r=16106

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -194 lines) Patch
M tests/standalone/black_listed_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/byte_array_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/crypto/base64_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/float_array_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/int_array_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/chunked_stream_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/compile_all_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/dart_std_io_pipe_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/directory_error_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/directory_fuzz_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/standalone/io/directory_invalid_arguments_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/directory_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/echo_server_stream_test.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M tests/standalone/io/echo_server_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/standalone/io/file_error_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/file_fuzz_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/standalone/io/file_input_stream_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/file_invalid_arguments_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/file_output_stream_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/file_system_links_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/file_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/fuzz_support.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/http_advanced_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/http_auth_test.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M tests/standalone/io/http_basic_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/http_client_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/standalone/io/http_connection_close_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/standalone/io/http_connection_header_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/http_connection_info_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/http_content_length_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/http_head_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/http_headers_state.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/http_proxy_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/http_read_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/http_redirect_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/http_server_early_client_close_test.dart View 1 chunk +2 lines, -2 lines 1 comment Download
M tests/standalone/io/http_server_early_server_close_test.dart View 1 chunk +2 lines, -2 lines 1 comment Download
M tests/standalone/io/http_server_socket_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/standalone/io/http_server_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/http_session_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/http_shutdown_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/list_input_stream_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/list_output_stream_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/many_directory_operations_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/many_file_operations_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/options_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/path_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/platform_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/print_env.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/process_broken_pipe_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/process_check_arguments_script.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/process_check_arguments_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/process_environment_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/standalone/io/process_exit_negative_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/process_exit_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/standalone/io/process_invalid_arguments_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/process_kill_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/standalone/io/process_path_environment_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/process_path_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/process_run_output_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/process_segfault_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/standalone/io/process_start_exception_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/process_std_io_script.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/process_std_io_script2.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/process_stderr_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/standalone/io/process_stdout_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/standalone/io/process_working_directory_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/standalone/io/read_into_const_list_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/regress-1925.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M tests/standalone/io/secure_socket_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/secure_stream_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/socket_close_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/socket_exception_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/socket_info_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/socket_invalid_arguments_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/socket_many_connections_test.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M tests/standalone/io/socket_port_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/socket_stream_close_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/status_file_parser_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/standalone/io/stream_pipe_test.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M tests/standalone/io/string_stream_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/test_extension.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/test_extension_fail_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/test_extension_fail_tester.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/standalone/io/test_extension_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/test_extension_tester.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/test_runner_exit_code_script.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/standalone/io/test_runner_exit_code_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/test_runner_test.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M tests/standalone/io/testing_server.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M tests/standalone/io/web_socket_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/windows_environment_script.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/windows_environment_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/medium_integer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/package/invalid_uri_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/package/package1_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/status_expression_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/typed_array_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Bill Hesse
Search and replace with sed, changing #library, #import, and #source to library, import, and part. ...
8 years ago (2012-12-13 12:15:26 UTC) #1
Mads Ager (google)
8 years ago (2012-12-13 12:33:21 UTC) #2 
LGTM

https://codereview.chromium.org/11570005/diff/1/tests/standalone/io/http_serv...
File tests/standalone/io/http_server_early_client_close_test.dart (right):

https://codereview.chromium.org/11570005/diff/1/tests/standalone/io/http_serv...
tests/standalone/io/http_server_early_client_close_test.dart:1: import
"dart:io";
Could you add a copyright to this one?

https://codereview.chromium.org/11570005/diff/1/tests/standalone/io/http_serv...
File tests/standalone/io/http_server_early_server_close_test.dart (right):

https://codereview.chromium.org/11570005/diff/1/tests/standalone/io/http_serv...
tests/standalone/io/http_server_early_server_close_test.dart:1: import
"dart:io";
Ditto

Powered by Google App Engine
This is Rietveld 408576698