Clean up process spawning.

Clean up process spawning.

Pass environment as argument to execvpe and use _exit instead of exit
(so fork/vfork can be used interchangeable).

BUG=
R=sgjesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/bbdc57ebf6a5f0a2646c88ce3c42ff866ab97599

[Anders Johnsen, 2015-06-05 20:45:17]

ajohnsen@google.com changed reviewers:
+ sgjesse@google.com

[Anders Johnsen, 2015-06-05 20:45:17]

Will port to android/mac when/if accepted.

[Søren Gjesse, 2015-06-10 07:20:25]

lgtm

https://codereview.chromium.org/1156313004/diff/1/runtime/bin/process_linux.cc
File runtime/bin/process_linux.cc (right):

https://codereview.chromium.org/1156313004/diff/1/runtime/bin/process_linux.c...
runtime/bin/process_linux.cc:413: _exit(1);
Good catch!

https://codereview.chromium.org/1156313004/diff/1/runtime/bin/process_linux.c...
runtime/bin/process_linux.cc:502: // Exit the intermeiate process.
Not you fault, but please change

intermeiate -> intermediate

https://codereview.chromium.org/1156313004/diff/1/runtime/bin/process_linux.c...
runtime/bin/process_linux.cc:507: // Exit the intermeiate process.
ditto.

https://codereview.chromium.org/1156313004/diff/1/runtime/bin/process_linux.c...
runtime/bin/process_linux.cc:670: void ReadChildError(int child_errno) {
Please rename this to e.g. SetOSErrorMessage.

[Anders Johnsen, 2015-06-10 08:00:45]

Added mac and android versions. PTAL

https://codereview.chromium.org/1156313004/diff/1/runtime/bin/process_linux.cc
File runtime/bin/process_linux.cc (right):

https://codereview.chromium.org/1156313004/diff/1/runtime/bin/process_linux.c...
runtime/bin/process_linux.cc:502: // Exit the intermeiate process.
On 2015/06/10 07:20:25, Søren Gjesse wrote:
> Not you fault, but please change
> 
> intermeiate -> intermediate

Done.

https://codereview.chromium.org/1156313004/diff/1/runtime/bin/process_linux.c...
runtime/bin/process_linux.cc:507: // Exit the intermeiate process.
On 2015/06/10 07:20:25, Søren Gjesse wrote:
> ditto.

Done.

https://codereview.chromium.org/1156313004/diff/1/runtime/bin/process_linux.c...
runtime/bin/process_linux.cc:670: void ReadChildError(int child_errno) {
On 2015/06/10 07:20:25, Søren Gjesse wrote:
> Please rename this to e.g. SetOSErrorMessage.

Done.

[Søren Gjesse, 2015-06-10 08:19:17]

lgtm

[Anders Johnsen, 2015-06-10 08:43:00]

Committed patchset #2 (id:20001) manually as
bbdc57ebf6a5f0a2646c88ce3c42ff866ab97599 (presubmit successful).

[kevmoo, 2015-06-10 10:06:41]

kevmoo@google.com changed reviewers:
+ kevmoo@google.com

[kevmoo, 2015-06-10 10:06:42]

DBQ

https://codereview.chromium.org/1156313004/diff/20001/tests/standalone/io/pla...
File tests/standalone/io/platform_executable_test.dart (left):

https://codereview.chromium.org/1156313004/diff/20001/tests/standalone/io/pla...
tests/standalone/io/platform_executable_test.dart:152:
testShouldFailOutsidePath(); /// 06: ok
This test existed for a very explicit reason: make sure running just 'dart' (or
'dart.exe') without the PATH set fails.