Chromium Code Reviews| Index: tests/standalone/io/platform_executable_test.dart |
| diff --git a/tests/standalone/io/platform_executable_test.dart b/tests/standalone/io/platform_executable_test.dart |
| index 1b6bce377de320ef95678ddda08efb6fb043792d..2b8af08a478326972639b71c9bcd886716f3c626 100644 |
| --- a/tests/standalone/io/platform_executable_test.dart |
| +++ b/tests/standalone/io/platform_executable_test.dart |
| @@ -43,20 +43,10 @@ void testDartExecShouldNotBeInCurrentDir() { |
| expectEquals(FileSystemEntityType.NOT_FOUND, type); |
| } |
| -void testShouldFailOutsidePath() { |
| - var threw = false; |
| - try { |
| - Process.runSync(platformExeName, ['--version'], |
| - includeParentEnvironment: false, |
| - environment: {_SCRIPT_KEY: 'yes', 'PATH': ''}); |
| - } catch (_) { |
| - threw = true; |
| - } |
| - |
| - if (!threw) { |
| - throw 'Expected running the dart executable – "$platformExeName" without' |
| - ' the parent environment or path to fail.'; |
| - } |
| +void testShouldSucceedWithEmptyPathEnvironment() { |
| + Process.runSync(platformExeName, ['--version'], |
| + includeParentEnvironment: false, |
| + environment: {_SCRIPT_KEY: 'yes', 'PATH': ''}); |
| } |
| void testShouldSucceedWithSourcePlatformExecutable() { |
| @@ -149,5 +139,5 @@ void main() { |
| testPathToSDKDir(); /// 03: ok |
| withTempDir(testPathPointsToSymLinkedSDKPath); /// 04: ok |
| withTempDir(testPathToDirWithExeSymLinked); /// 05: ok |
| - testShouldFailOutsidePath(); /// 06: ok |
|
kevmoo
2015/06/10 10:06:42
This test existed for a very explicit reason: make
|
| + testShouldSucceedWithEmptyPathEnvironment(); /// 06: ok |
| } |