Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1156053006: - Determine whether the simulator is being used in globals.h (Closed)

Created:
5 years, 6 months ago by Ivan Posva
Modified:
5 years, 6 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

- Determine whether the simulator is being used in globals.h - Make sure to switch on HOST_ARCH_ and on USING_SIMULATOR where appropriate. - Avoid allocating in new generation when running in the VM isolate. BUG= R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/8f1506e8172ca6817ca49bdd92ce0b7360aa53d9

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -172 lines) Patch
M runtime/platform/globals.h View 1 4 chunks +35 lines, -1 line 0 comments Download
M runtime/vm/cpu_arm.cc View 6 chunks +7 lines, -8 lines 0 comments Download
M runtime/vm/cpu_arm64.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M runtime/vm/cpu_mips.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/os_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/os_linux.cc View 1 chunk +1 line, -11 lines 0 comments Download
M runtime/vm/os_macos.cc View 1 chunk +1 line, -5 lines 0 comments Download
M runtime/vm/os_win.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/signal_handler_android.cc View 4 chunks +20 lines, -20 lines 0 comments Download
M runtime/vm/signal_handler_linux.cc View 4 chunks +28 lines, -52 lines 0 comments Download
M runtime/vm/signal_handler_macos.cc View 3 chunks +23 lines, -29 lines 0 comments Download
M runtime/vm/simulator.h View 1 chunk +5 lines, -24 lines 0 comments Download
M runtime/vm/simulator_arm.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/simulator_arm.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/simulator_arm64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/simulator_mips.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/snapshot.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Ivan Posva
5 years, 6 months ago (2015-05-29 16:48:57 UTC) #2
srdjan
lgtm https://codereview.chromium.org/1156053006/diff/1/runtime/platform/globals.h File runtime/platform/globals.h (right): https://codereview.chromium.org/1156053006/diff/1/runtime/platform/globals.h#newcode278 runtime/platform/globals.h:278: #if !defined(HOST_ARCH_ARM) || TARGET_OS_IPHONE || defined(TARGET_OS_IPHONE) ? (also ...
5 years, 6 months ago (2015-05-29 16:58:56 UTC) #3
Ivan Posva
https://codereview.chromium.org/1156053006/diff/1/runtime/platform/globals.h File runtime/platform/globals.h (right): https://codereview.chromium.org/1156053006/diff/1/runtime/platform/globals.h#newcode278 runtime/platform/globals.h:278: #if !defined(HOST_ARCH_ARM) || TARGET_OS_IPHONE On 2015/05/29 16:58:56, srdjan wrote: ...
5 years, 6 months ago (2015-05-29 17:25:36 UTC) #4
Ivan Posva
Address review comments
5 years, 6 months ago (2015-05-29 21:32:54 UTC) #5
Ivan Posva
5 years, 6 months ago (2015-05-29 21:35:35 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
8f1506e8172ca6817ca49bdd92ce0b7360aa53d9.

Powered by Google App Engine
This is Rietveld 408576698