Make listDir always emit paths within the given directory.

Make listDir always emit paths within the given directory.

BUG=7346
Committed: https://code.google.com/p/dart/source/detail?r=16275

[Bob Nystrom, 2012-12-13 19:54:54]

I'm hesitant about this. Doing our own recursive search means we need to handle
symlink cycles and other weird corner cases.

How about file we file a dart:io bug and see what they think? I think
Directory.list() itself should be guaranteed to only return paths that are
within the path of the directory.

[Bob Nystrom, 2012-12-17 23:42:33]

https://codereview.chromium.org/11553043/diff/4001/utils/pub/io.dart
File utils/pub/io.dart (right):

https://codereview.chromium.org/11553043/diff/4001/utils/pub/io.dart#newcode257
utils/pub/io.dart:257: Set<String> _listedDirectories}) {
Instead of making this an optional parameter, how about splitting this into the
public method without it, and a separate private method that requires this and
does the recursion. I find the nested recursive async control flow a bit hard to
read here.

[nweiz, 2012-12-18 18:38:43]

https://codereview.chromium.org/11553043/diff/4001/utils/pub/io.dart
File utils/pub/io.dart (right):

https://codereview.chromium.org/11553043/diff/4001/utils/pub/io.dart#newcode257
utils/pub/io.dart:257: Set<String> _listedDirectories}) {
On 2012/12/17 23:42:33, Bob Nystrom wrote:
> Instead of making this an optional parameter, how about splitting this into
the
> public method without it, and a separate private method that requires this and
> does the recursion. I find the nested recursive async control flow a bit hard
to
> read here.

Done.

[Bob Nystrom, 2012-12-18 18:58:29]

LGTM!