Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1704)

Unified Diff: utils/pub/validator/lib.dart

Issue 11553043: Make listDir always emit paths within the given directory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review change. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « utils/pub/io.dart ('k') | utils/tests/pub/io_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/pub/validator/lib.dart
diff --git a/utils/pub/validator/lib.dart b/utils/pub/validator/lib.dart
index 39b71afa45383b2bc9d210c7804b5e37e4dc9292..b0dfbe5e51c0b70e1d287c7835586202815961fb 100644
--- a/utils/pub/validator/lib.dart
+++ b/utils/pub/validator/lib.dart
@@ -29,13 +29,6 @@ class LibValidator extends Validator {
return new Future.immediate(null);
}
- // TODO(rnystrom): listDir() returns real file paths after symlinks are
- // resolved. This means if libDir contains a symlink, the resulting paths
- // won't appear to be within it, which confuses relativeTo(). Work around
- // that here by making sure we have the real path to libDir. Remove this
- // when #7346 is fixed.
- libDir = new File(libDir).fullPathSync();
-
return listDir(libDir).transform((files) {
files = files.map((file) => relativeTo(file, libDir));
if (files.isEmpty) {
« no previous file with comments | « utils/pub/io.dart ('k') | utils/tests/pub/io_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698