Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Issue 11553015: Add a fall-back for novel HTML Elements (Closed)

Created:
8 years ago by sra1
Modified:
8 years ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add a fall-back for novel HTML Elements Browsers keep adding new HTMLElements, the latest is Chrome 25 with HTMLTemplateElement. Rather that dying, treat unknown elements as a plain HTMLElement. This at least allows access to basic generic operations, which is often all that is required. Committed: https://code.google.com/p/dart/source/detail?r=16020

Patch Set 1 : #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -25 lines) Patch
M sdk/lib/_internal/compiler/implementation/lib/native_helper.dart View 5 chunks +49 lines, -25 lines 1 comment Download
A tests/compiler/dart2js_native/native_novel_html_test.dart View 1 chunk +55 lines, -0 lines 3 comments Download

Messages

Total messages: 3 (0 generated)
sra1
This needs to be in M2 for web_ui to run on Chrome 25 which is ...
8 years ago (2012-12-12 06:34:56 UTC) #1
kasperl
LGTM! https://codereview.chromium.org/11553015/diff/4001/sdk/lib/_internal/compiler/implementation/lib/native_helper.dart File sdk/lib/_internal/compiler/implementation/lib/native_helper.dart (right): https://codereview.chromium.org/11553015/diff/4001/sdk/lib/_internal/compiler/implementation/lib/native_helper.dart#newcode240 sdk/lib/_internal/compiler/implementation/lib/native_helper.dart:240: if (altTag != null) { Nit: I'd try ...
8 years ago (2012-12-12 06:43:50 UTC) #2
ngeoffray
8 years ago (2012-12-12 08:14:10 UTC) #3
Message was sent while issue was closed.
LGTM

https://codereview.chromium.org/11553015/diff/4001/tests/compiler/dart2js_nat...
File tests/compiler/dart2js_native/native_novel_html_test.dart (right):

https://codereview.chromium.org/11553015/diff/4001/tests/compiler/dart2js_nat...
tests/compiler/dart2js_native/native_novel_html_test.dart:1: // Copyright (c)
2011, the Dart project authors.  Please see the AUTHORS file
2011 is so almost 2 years ago :-)

Powered by Google App Engine
This is Rietveld 408576698