Add a fall-back for novel HTML Elements

sdk/lib/_internal/compiler/implementation/lib/native_helper.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of _js_helper;
 
 String typeNameInChrome(obj) {
   String name = JS('String', "#.constructor.name", obj);
-  if (name == 'Window') return 'DOMWindow';
-  if (name == 'CanvasPixelArray') return 'Uint8ClampedArray';
-  if (name == 'WebKitMutationObserver') return 'MutationObserver';
-  if (name == 'AudioChannelMerger') return 'ChannelMergerNode';
-  if (name == 'AudioChannelSplitter') return 'ChannelSplitterNode';
-  if (name == 'AudioGainNode') return 'GainNode';
-  if (name == 'AudioPannerNode') return 'PannerNode';
-  if (name == 'JavaScriptAudioNode') return 'ScriptProcessorNode';
-  if (name == 'Oscillator') return 'OscillatorNode';
-  if (name == 'RealtimeAnalyserNode') return 'AnalyserNode';
-  return name;
+  return typeNameInWebKitCommon(name);
 }
 
 String typeNameInSafari(obj) {
   String name = JS('String', '#', constructorNameFallback(obj));
   // Safari is very similar to Chrome.
+  return typeNameInWebKitCommon(name);
+}
+
+String typeNameInWebKitCommon(tag) {
+  String name = JS('String', '#', tag);
   if (name == 'Window') return 'DOMWindow';
   if (name == 'CanvasPixelArray') return 'Uint8ClampedArray';
   if (name == 'WebKitMutationObserver') return 'MutationObserver';
   if (name == 'AudioChannelMerger') return 'ChannelMergerNode';
   if (name == 'AudioChannelSplitter') return 'ChannelSplitterNode';
   if (name == 'AudioGainNode') return 'GainNode';
   if (name == 'AudioPannerNode') return 'PannerNode';
   if (name == 'JavaScriptAudioNode') return 'ScriptProcessorNode';
   if (name == 'Oscillator') return 'OscillatorNode';
   if (name == 'RealtimeAnalyserNode') return 'AnalyserNode';
@@ skipping 60 matching lines @@
         && !identical(name, '')
         && !identical(name, 'Object')
         && !identical(name, 'Function.prototype')) {  // Can happen in Opera.
       return name;
     }
   }
   String string = JS('String', 'Object.prototype.toString.call(#)', object);
   return JS('String', '#.substring(8, # - 1)', string, string.length);
 }
 
+/**
+ * If a lookup on an object [object] that has [tag] fails, this function is
+ * called to provide an alternate tag.  This allows us to fail gracefully if we
+ * can make a good guess, for example, when browsers add novel kinds of
+ * HTMLElement that we have never heard of.
+ */
+String alternateTag(object, String tag) {
+  // Does it smell like some kind of HTML element?
+  if (JS('bool', r'!!/^HTML[A-Z].*Element$/.test(#)', tag)) {
+    // Check that it is not a simple JavaScript object.
+    String string = JS('String', 'Object.prototype.toString.call(#)', object);
+    if (string == '[object Object]') return null;
+    return 'HTMLElement';
+  }
+  return null;
+}
+
 // TODO(ngeoffray): stop using this method once our optimizers can
 // change str1.contains(str2) into str1.indexOf(str2) != -1.
 bool contains(String userAgent, String name) {
   return JS('int', '#.indexOf(#)', userAgent, name) != -1;
 }
 
 int arrayLength(List array) {
   return JS('int', '#.length', array);
 }
 
@@ skipping 71 matching lines @@
   String name = JS('String', '#', getTypeNameOf(obj));
   return 'Instance of $name';
 }
 
 int hashCodeForNativeObject(object) => Primitives.objectHashCode(object);
 
 /**
  * Sets a JavaScript property on an object.
  */
 void defineProperty(var obj, String property, var value) {
-  JS('void', """Object.defineProperty(#, #,
-      {value: #, enumerable: false, writable: true, configurable: true})""",
+  JS('void',
+      'Object.defineProperty(#, #, '
+          '{value: #, enumerable: false, writable: true, configurable: true})',
       obj,
       property,
       value);
 }
 
 /**
  * This method looks up the type name of [obj] in [methods]. [methods]
  * is a Javascript object. If it cannot find it, it looks into the
  * [_dynamicMetadata] array. If the method can still not be found, it
  * creates a method that will throw a [NoSuchMethodError].
  *
  * Once it has a method, the prototype of [obj] is patched with that
  * method, on the property [name]. The method is then invoked.
  *
  * This method returns the result of invoking the found method.
  */
 dynamicBind(var obj,
             String name,
             var methods,
             List arguments) {
   // The tag is related to the class name.  E.g. the dart:html class
   // '_ButtonElement' has the tag 'HTMLButtonElement'.  TODO(erikcorry): rename
   // getTypeNameOf to getTypeTag.
   String tag = getTypeNameOf(obj);
   var hasOwnPropertyFunction = JS('var', 'Object.prototype.hasOwnProperty');
-  var method = lookupDynamicClass(hasOwnPropertyFunction, methods, tag);
 
-  if (method == null && _dynamicMetadata != null) {
-    // Look at the inheritance data, getting the class tags and using them
-    // to check the methods table for this method name.
-    for (int i = 0; i < arrayLength(_dynamicMetadata); i++) {
-      MetaInfo entry = arrayGet(_dynamicMetadata, i);
-      if (callHasOwnProperty(hasOwnPropertyFunction, entry._set, tag)) {
-        method =
-            lookupDynamicClass(hasOwnPropertyFunction, methods, entry._tag);
-        // Stop if we found it in the methods array.
-        if (method != null) break;
-      }
+  var method = dynamicBindLookup(hasOwnPropertyFunction, tag, methods);
+  if (method == null) {
+    String altTag = alternateTag(obj, tag);
+    if (altTag != null) {

[kasperl, 2012/12/12 06:43:50]

Nit: I'd try to avoid the abbreviation of alt.

+      method = dynamicBindLookup(hasOwnPropertyFunction, altTag, methods);
     }
   }
 
   // If we didn't find the method then look up in the Dart Object class, using
   // getTypeNameOf in case the minifier has renamed Object.
   if (method == null) {
     String nameOfObjectClass = getTypeNameOf(const Object());
     method =
         lookupDynamicClass(hasOwnPropertyFunction, methods, nameOfObjectClass);
   }
@@ skipping 15 matching lines @@
       proto, name, name);
   }
 
   if (!callHasOwnProperty(hasOwnPropertyFunction, proto, name)) {
     defineProperty(proto, name, method);
   }
 
   return JS('var', '#.apply(#, #)', method, obj, arguments);
 }
 
+dynamicBindLookup(var hasOwnPropertyFunction, String tag, var methods) {
+  var method = lookupDynamicClass(hasOwnPropertyFunction, methods, tag);
+  // Look at the inheritance data, getting the class tags and using them
+  // to check the methods table for this method name.
+  if (method == null && _dynamicMetadata != null) {
+    for (int i = 0; i < arrayLength(_dynamicMetadata); i++) {
+      MetaInfo entry = arrayGet(_dynamicMetadata, i);
+      if (callHasOwnProperty(hasOwnPropertyFunction, entry._set, tag)) {
+        method =
+            lookupDynamicClass(hasOwnPropertyFunction, methods, entry._tag);
+        // Stop if we found it in the methods array.
+        if (method != null) break;
+      }
+    }
+  }
+  return method;
+}
+
 // For each method name and class inheritance subtree, we use an ordinary JS
 // object as a hash map to store the method for each class.  Entries are added
 // in native_emitter.dart (see dynamicName).  In order to avoid the class names
 // clashing with the method names on Object.prototype (needed for native
 // objects) we must always use hasOwnProperty.
 var lookupDynamicClass(var hasOwnPropertyFunction,
                        var methods,
                        String className) {
   return callHasOwnProperty(hasOwnPropertyFunction, methods, className) ?
          propertyGet(methods, className) :
@@ skipping 108 matching lines @@
   }
   return result;
 }
 
 /**
  * Called by the compiler to setup [_dynamicMetadata].
  */
 void dynamicSetMetadata(List<List<String>> inputTable) {
   _dynamicMetadata = buildDynamicMetadata(inputTable);
 }