Issue 11549010: Dynamically Allocate the predefined handles structure in Symbols

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11549010: Dynamically Allocate the predefined handles structure in Symbols (Closed)

Created:
8 years ago by siva

Modified:
8 years ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Dynamically Allocate the predefined handles structure in Symbols so that an "exit" will not result in static destructors being run and zapping the handles area while some other isolates are still running. Committed: https://code.google.com/p/dart/source/detail?r=16015

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -7 lines)			Patch
	M	vm/symbols.h	View		1 chunk	+21 lines, -4 lines	0 comments	Download
	M	vm/symbols.cc	View		3 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

8 years ago (2012-12-12 02:38:56 UTC) #2

LGTM, but we will need to come up with a strategy to cleanly shutdown the
process.

-Ivan

Expand Messages | Collapse Messages