Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: vm/symbols.cc

Issue 11549010: Dynamically Allocate the predefined handles structure in Symbols (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/symbols.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/symbols.cc
===================================================================
--- vm/symbols.cc (revision 16012)
+++ vm/symbols.cc (working copy)
@@ -17,8 +17,9 @@
namespace dart {
RawString* Symbols::predefined_[Symbols::kMaxId];
-VMHandles Symbols::predefined_handles_;
+Symbols::ReadOnlyHandles* Symbols::predefined_handles_ = NULL;
+
#define DEFINE_SYMBOL_HANDLE(symbol) \
String* Symbols::symbol##_handle_ = NULL;
PREDEFINED_SYMBOL_HANDLES_LIST(DEFINE_SYMBOL_HANDLE)
@@ -80,9 +81,10 @@
predefined_[kMaxPredefinedId + c] = FromUTF32(&c, 1);
}
+ predefined_handles_ = new ReadOnlyHandles();
#define INITIALIZE_SYMBOL_HANDLE(symbol) \
symbol##_handle_ = reinterpret_cast<String*>( \
- predefined_handles_.AllocateScopedHandle()); \
+ predefined_handles_->AllocateHandle()); \
*symbol##_handle_ = symbol();
PREDEFINED_SYMBOL_HANDLES_LIST(INITIALIZE_SYMBOL_HANDLE)
#undef INITIALIZE_SYMBOL_HANDLE
@@ -276,7 +278,7 @@
bool Symbols::IsPredefinedHandle(uword address) {
- return predefined_handles_.IsValidScopedHandle(address);
+ return predefined_handles_->IsValidHandle(address);
}
« no previous file with comments | « vm/symbols.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698