Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 1154773002: Remove return in visitInitializers. (Closed)

Created:
5 years, 7 months ago by Johnni Winther
Modified:
5 years, 7 months ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -2 lines) Patch
M pkg/compiler/lib/src/resolution/semantic_visitor.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test.dart View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
5 years, 7 months ago (2015-05-22 07:09:07 UTC) #2
Anders Johnsen
LGTM (btw, cool testing framework)
5 years, 7 months ago (2015-05-22 07:10:25 UTC) #3
Johnni Winther
5 years, 7 months ago (2015-05-22 07:11:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
46ad1c4e9a9038b4789d5661f59a0bbe0f532c17 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698