Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: pkg/compiler/lib/src/resolution/semantic_visitor.dart

Issue 1154773002: Remove return in visitInitializers. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tests/compiler/dart2js/semantic_visitor_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library dart2js.semantics_visitor; 5 library dart2js.semantics_visitor;
6 6
7 import '../constants/expressions.dart'; 7 import '../constants/expressions.dart';
8 import '../dart2jslib.dart' show invariant, MessageKind; 8 import '../dart2jslib.dart' show invariant, MessageKind;
9 import '../dart_types.dart'; 9 import '../dart_types.dart';
10 import '../elements/elements.dart'; 10 import '../elements/elements.dart';
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 } else { 89 } else {
90 return structure.dispatch(declVisitor, node, arg); 90 return structure.dispatch(declVisitor, node, arg);
91 } 91 }
92 } 92 }
93 93
94 visitInitializers(NodeList initializers, A arg) { 94 visitInitializers(NodeList initializers, A arg) {
95 if (initializers != null) { 95 if (initializers != null) {
96 for (Node node in initializers) { 96 for (Node node in initializers) {
97 InitializerStructure structure = computeInitializerStructure(node); 97 InitializerStructure structure = computeInitializerStructure(node);
98 if (structure == null) { 98 if (structure == null) {
99 return internalError(node, 'No structure for $node'); 99 internalError(node, 'No structure for $node');
100 } else { 100 } else {
101 return structure.dispatch(declVisitor, node, arg); 101 structure.dispatch(declVisitor, node, arg);
102 } 102 }
103 } 103 }
104 } 104 }
105 } 105 }
106 106
107 visitParameters(NodeList parameters, A arg) { 107 visitParameters(NodeList parameters, A arg) {
108 List<ParameterStructure> structures = 108 List<ParameterStructure> structures =
109 computeParameterStructures(parameters); 109 computeParameterStructures(parameters);
110 for (ParameterStructure structure in structures) { 110 for (ParameterStructure structure in structures) {
111 structure.dispatch(declVisitor, arg); 111 structure.dispatch(declVisitor, arg);
(...skipping 4309 matching lines...) Expand 10 before | Expand all | Expand 10 after
4421 /// C() : this._(42); 4421 /// C() : this._(42);
4422 /// } 4422 /// }
4423 /// 4423 ///
4424 R errorUnresolvedThisConstructorInvoke( 4424 R errorUnresolvedThisConstructorInvoke(
4425 Send node, 4425 Send node,
4426 Element element, 4426 Element element,
4427 NodeList arguments, 4427 NodeList arguments,
4428 Selector selector, 4428 Selector selector,
4429 A arg); 4429 A arg);
4430 } 4430 }
OLDNEW
« no previous file with comments | « no previous file | tests/compiler/dart2js/semantic_visitor_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698