Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 1154743004: Test (and fix some) invalid assignments. (Closed)

Created:
5 years, 7 months ago by Johnni Winther
Modified:
5 years, 7 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+711 lines, -43 lines) Patch
M pkg/compiler/lib/src/resolution/members.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_resolver.dart View 1 1 chunk +7 lines, -1 line 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test.dart View 51 chunks +681 lines, -24 lines 0 comments Download
A + tests/language/final_super_field_set_test.dart View 1 chunk +9 lines, -7 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +1 line, -0 lines 0 comments Download
A + tests/language/static_setter_get_test.dart View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
https://codereview.chromium.org/1154743004/diff/1/tests/compiler/dart2js/semantic_visitor_test.dart File tests/compiler/dart2js/semantic_visitor_test.dart (right): https://codereview.chromium.org/1154743004/diff/1/tests/compiler/dart2js/semantic_visitor_test.dart#newcode4628 tests/compiler/dart2js/semantic_visitor_test.dart:4628: super.visitDynamicTypeLiteralSet(node, constant, rhs, arg); Changed to test the implementation ...
5 years, 7 months ago (2015-05-22 11:46:03 UTC) #2
karlklose
LGTM. https://codereview.chromium.org/1154743004/diff/1/pkg/compiler/lib/src/resolution/send_resolver.dart File pkg/compiler/lib/src/resolution/send_resolver.dart (right): https://codereview.chromium.org/1154743004/diff/1/pkg/compiler/lib/src/resolution/send_resolver.dart#newcode433 pkg/compiler/lib/src/resolution/send_resolver.dart:433: //print('$node,element=$element,getter=$getter'); Remove debug code. https://codereview.chromium.org/1154743004/diff/1/tests/language/language_dart2js.status File tests/language/language_dart2js.status (right): ...
5 years, 7 months ago (2015-05-22 12:14:19 UTC) #3
Johnni Winther
5 years, 7 months ago (2015-05-22 13:00:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4013583d3f7fc9b5994b700e8955be8d1c8f05f9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698