Test (and fix some) invalid assignments.

tests/compiler/dart2js/semantic_visitor_test.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.semantics_visitor_test;
 
 import 'dart:async';
 import 'dart:mirrors';
 import 'package:async_helper/async_helper.dart';
 import 'package:expect/expect.dart';
@@ skipping 159 matching lines @@
                     element: 'parameter(m#o)')),
     const Test('m(o) { o = 42; }',
         const Visit(VisitKind.VISIT_PARAMETER_SET,
                     element: 'parameter(m#o)',
                     rhs:'42')),
     const Test('m(o) { o(null, 42); }',
         const Visit(VisitKind.VISIT_PARAMETER_INVOKE,
                     element: 'parameter(m#o)',
                     arguments: '(null,42)',
                     selector: 'CallStructure(arity=2)')),
+    // TODO(johnniwinther): Expect [VISIT_FINAL_PARAMETER_SET] instead.
+    const Test('m(final o) { o = 42; }',
+        const Visit(VisitKind.VISIT_UNRESOLVED_SET,
+                    name: 'o',
+                    rhs:'42')),
   ],
   'Local variables': const [
     // Local variables
     const Test('m() { var o; return o; }',
         const Visit(VisitKind.VISIT_LOCAL_VARIABLE_GET,
                     element: 'variable(m#o)')),
     const Test('m() { var o; o = 42; }',
         const Visit(VisitKind.VISIT_LOCAL_VARIABLE_SET,
                     element: 'variable(m#o)',
                     rhs:'42')),
     const Test('m() { var o; o(null, 42); }',
         const Visit(VisitKind.VISIT_LOCAL_VARIABLE_INVOKE,
                     element: 'variable(m#o)',
                     arguments: '(null,42)',
                     selector: 'CallStructure(arity=2)')),
+    // TODO(johnniwinther): Expect [VISIT_FINAL_LOCAL_VARIABLE_SET] instead.
+    const Test('m() { final o = 0; o = 42; }',
+        const Visit(VisitKind.VISIT_UNRESOLVED_SET,
+                    name: 'o',
+                    rhs:'42')),
+    // TODO(johnniwinther): Expect [VISIT_FINAL_LOCAL_VARIABLE_SET] instead.
+    const Test('m() { const o = 0; o = 42; }',
+        const Visit(VisitKind.VISIT_UNRESOLVED_SET,
+                    name: 'o',
+                    rhs:'42')),
   ],
   'Local functions': const [
     // Local functions
     const Test('m() { o(a, b) {}; return o; }',
         const Visit(VisitKind.VISIT_LOCAL_FUNCTION_GET,
                     element: 'function(m#o)')),
     const Test('m() { o(a, b) {}; o(null, 42); }',
         const Visit(VisitKind.VISIT_LOCAL_FUNCTION_INVOKE,
                     element: 'function(m#o)',
                     arguments: '(null,42)',
                     selector: 'CallStructure(arity=2)')),
+    // TODO(johnniwinther): Expect [VISIT_LOCAL_FUNCTION_SET] instead.
+    const Test('m() { o(a, b) {}; o = 42; }',
+        const Visit(VisitKind.VISIT_UNRESOLVED_SET,
+                    name: 'o',
+                    rhs: '42')),
   ],
   'Static fields': const [
     // Static fields
     const Test(
         '''
         class C { static var o; }
         m() => C.o;
         ''',
         const Visit(VisitKind.VISIT_STATIC_FIELD_GET,
                     element: 'field(C#o)')),
@@ skipping 93 matching lines @@
     const Test.prefix(
         '''
         class C {
           static var o;
         }
         ''',
         'm() { p.C.o(null, 42); }',
         const Visit(VisitKind.VISIT_STATIC_FIELD_INVOKE,
                     element: 'field(C#o)',
                     arguments: '(null,42)')),
+    // TODO(johnniwinther): Expect [VISIT_FINAL_STATIC_FIELD_SET] instead.
+    const Test(
+        '''
+        class C { static final o = 0; }
+        m() { C.o = 42; }
+        ''',
+        const Visit(VisitKind.VISIT_UNRESOLVED_SET,
+                    name: 'o',
+                    rhs: '42')),
+    const Test.clazz(
+        '''
+        class C {
+          static final o = 0;
+          m() { o = 42; }
+        }
+        ''',
+        const Visit(VisitKind.VISIT_UNRESOLVED_SET,
+                    name: 'o',
+                    rhs: '42')),
+    const Test.clazz(
+        '''
+        class C {
+          static final o = 0;
+          m() { C.o = 42; }
+        }
+        ''',
+        const Visit(VisitKind.VISIT_UNRESOLVED_SET,
+                    name: 'o',
+                    rhs: '42')),
+    const Test.prefix(
+        '''
+        class C {
+          static final o = 0;
+        }
+        ''',
+        'm() { p.C.o = 42; }',
+        const Visit(VisitKind.VISIT_UNRESOLVED_SET,
+                    name: 'o',
+                    rhs: '42')),
+    const Test(
+        '''
+        class C { static const o = 0; }
+        m() { C.o = 42; }
+        ''',
+        const Visit(VisitKind.VISIT_UNRESOLVED_SET,
+                    name: 'o',
+                    rhs: '42')),
+    const Test.clazz(
+        '''
+        class C {
+          static const o = 0;
+          m() { o = 42; }
+        }
+        ''',
+        const Visit(VisitKind.VISIT_UNRESOLVED_SET,
+                    name: 'o',
+                    rhs: '42')),
+    const Test.clazz(
+        '''
+        class C {
+          static const o = 0;
+          m() { C.o = 42; }
+        }
+        ''',
+        const Visit(VisitKind.VISIT_UNRESOLVED_SET,
+                    name: 'o',
+                    rhs: '42')),
+    const Test.prefix(
+        '''
+        class C {
+          static const o = 0;
+        }
+        ''',
+        'm() { p.C.o = 42; }',
+        const Visit(VisitKind.VISIT_UNRESOLVED_SET,
+                    name: 'o',
+                    rhs: '42')),
   ],
   'Static properties': const [
     // Static properties
     const Test(
         '''
         class C {
           static get o => null;
         }
         m() => C.o;
         ''',
@@ skipping 19 matching lines @@
                     element: 'getter(C#o)')),
     const Test.prefix(
         '''
         class C {
           static get o => null;
         }
         ''',
         'm() => p.C.o;',
         const Visit(VisitKind.VISIT_STATIC_GETTER_GET,
                     element: 'getter(C#o)')),
+    // TODO(johnniwinther): Expected [VISIT_STATIC_GETTER_SET] instead.
+    const Test(
+        '''
+        class C { static get o => 42; }
+        m() { C.o = 42; }
+        ''',
+        const Visit(VisitKind.VISIT_UNRESOLVED_SET,
+                    name: 'o',
+                    rhs: '42')),
+    const Test.clazz(
+        '''
+        class C {
+          static static get o => 42;
+          m() { o = 42; }
+        }
+        ''',
+        const Visit(VisitKind.VISIT_UNRESOLVED_SET,
+                    name: 'o',
+                    rhs: '42')),
+    const Test.clazz(
+        '''
+        class C {
+          static static get o => 42;
+          m() { C.o = 42; }
+        }
+        ''',
+        const Visit(VisitKind.VISIT_UNRESOLVED_SET,
+                    name: 'o',
+                    rhs: '42')),
+    const Test.prefix(
+        '''
+        class C {
+          static static get o => 42;
+        }
+        ''',
+        'm() { p.C.o = 42; }',
+        const Visit(VisitKind.VISIT_UNRESOLVED_SET,
+                    name: 'o',
+                    rhs: '42')),
+    // TODO(johnniwinther): Expected [VISIT_STATIC_SETTER_GET] instead.
+    const Test(
+        '''
+        class C {
+          static set o(_) {}
+        }
+        m() => C.o;
+        ''',
+        const Visit(VisitKind.VISIT_UNRESOLVED_GET,
+                    name: 'o')),
+    const Test.clazz(
+        '''
+        class C {
+          static set o(_) {}
+          m() => o;
+        }
+        ''',
+        const Visit(VisitKind.VISIT_UNRESOLVED_GET,
+                    name: 'o')),
+    const Test.clazz(
+        '''
+        class C {
+          static set o(_) {}
+          m() => C.o;
+        }
+        ''',
+        const Visit(VisitKind.VISIT_UNRESOLVED_GET,
+                    name: 'o')),
+    const Test.prefix(
+        '''
+        class C {
+          static set o(_) {}
+        }
+        ''',
+        'm() => p.C.o;',
+        const Visit(VisitKind.VISIT_UNRESOLVED_GET,
+                    name: 'o')),
     const Test(
         '''
         class C { static set o(_) {} }
         m() { C.o = 42; }
         ''',
         const Visit(VisitKind.VISIT_STATIC_SETTER_SET,
                     element: 'setter(C#o)',
                     rhs: '42')),
     const Test.clazz(
         '''
@@ skipping 56 matching lines @@
     const Test.prefix(
         '''
         class C {
           static get o => null;
         }
         ''',
         'm() { p.C.o(null, 42); }',
         const Visit(VisitKind.VISIT_STATIC_GETTER_INVOKE,
                     element: 'getter(C#o)',
                     arguments: '(null,42)')),
+    // TODO(johnniwinther): Expect [VISIT_STATIC_SETTER_INVOKE] instead.
+    const Test(
+        '''
+        class C { static set o(_) {} }
+        m() => C.o(null, 42);
+        ''',
+        const Visit(VisitKind.VISIT_UNRESOLVED_INVOKE,
+                    name: 'o',
+                    arguments: '(null,42)')),
+    const Test.clazz(
+        '''
+        class C {
+          static set o(_) {}
+          m() { o(null, 42); }
+        }
+        ''',
+        const Visit(VisitKind.VISIT_UNRESOLVED_INVOKE,
+                    name: 'o',
+                    arguments: '(null,42)')),
+    const Test.clazz(
+        '''
+        class C {
+          static set o(_) {}
+          m() { C.o(null, 42); }
+        }
+        ''',
+        const Visit(VisitKind.VISIT_UNRESOLVED_INVOKE,
+                    name: 'o',
+                    arguments: '(null,42)')),
+    const Test.prefix(
+        '''
+        class C {
+          static set o(_) {}
+        }
+        ''',
+        'm() { p.C.o(null, 42); }',
+        const Visit(VisitKind.VISIT_UNRESOLVED_INVOKE,
+                    name: 'o',
+                    arguments: '(null,42)')),
   ],
   'Static functions': const [
     // Static functions
     const Test(
         '''
         class C { static o(a, b) {} }
         m() => C.o;
         ''',
         const Visit(VisitKind.VISIT_STATIC_FUNCTION_GET,
                     element: 'function(C#o)')),
@@ skipping 17 matching lines @@
                     element: 'function(C#o)')),
     const Test.prefix(
         '''
         class C { static o(a, b) {} }
         ''',
         '''
         m() => p.C.o;
         ''',
         const Visit(VisitKind.VISIT_STATIC_FUNCTION_GET,
                     element: 'function(C#o)')),
+    // TODO(johnniwinther): Expect [VISIT_STATIC_FUNCTION_SET] instead.
     const Test(
         '''
         class C { static o(a, b) {} }
+        m() { C.o = 42; }
+        ''',
+        const Visit(VisitKind.VISIT_UNRESOLVED_SET,
+                    name: 'o',
+                    rhs: '42')),
+    const Test.clazz(
+        '''
+        class C {
+          static o(a, b) {}
+          m() { o = 42; }
+        }
+        ''',
+        const Visit(VisitKind.VISIT_UNRESOLVED_SET,
+                    name: 'o',
+                    rhs: '42')),
+    const Test.clazz(
+        '''
+        class C {
+          static o(a, b) {}
+          m() { C.o = 42; }
+        }
+        ''',
+        const Visit(VisitKind.VISIT_UNRESOLVED_SET,
+                    name: 'o',
+                    rhs: '42')),
+    const Test.prefix(
+        '''
+        class C { static o(a, b) {} }
+        ''',
+        '''
+        m() { p.C.o = 42; }
+        ''',
+        const Visit(VisitKind.VISIT_UNRESOLVED_SET,
+                    name: 'o',
+                    rhs: '42')),
+    const Test(
+        '''
+        class C { static o(a, b) {} }
         m() => C.o(null, 42);
         ''',
         const Visit(VisitKind.VISIT_STATIC_FUNCTION_INVOKE,
                     element: 'function(C#o)',
                     arguments: '(null,42)')),
     const Test.clazz(
         '''
         class C {
           static o(a, b) {}
           m() { o(null, 42); }
@@ skipping 56 matching lines @@
                     element: 'field(o)',
                     rhs: '42')),
     const Test.prefix(
         '''
         var o;
         ''',
         'm() { p.o = 42; }',
         const Visit(VisitKind.VISIT_TOP_LEVEL_FIELD_SET,
                     element: 'field(o)',
                     rhs: '42')),
+    // TODO(johnniwinther): Expect [VISIT_FINAL_TOP_LEVEL_FIELD_SET] instead.
+    const Test(
+        '''
+        final o = 0;
+        m() { o = 42; }
+        ''',
+        const Visit(VisitKind.VISIT_UNRESOLVED_SET,
+                    name: 'o',
+                    rhs: '42')),
+    const Test.prefix(
+        '''
+        final o = 0;
+        ''',
+        'm() { p.o = 42; }',
+        const Visit(VisitKind.VISIT_UNRESOLVED_SET,
+                    name: 'o',
+                    rhs: '42')),
+    const Test(
+        '''
+        const o = 0;
+        m() { o = 42; }
+        ''',
+        const Visit(VisitKind.VISIT_UNRESOLVED_SET,
+                    name: 'o',
+                    rhs: '42')),
+    const Test.prefix(
+        '''
+        const o = 0;
+        ''',
+        'm() { p.o = 42; }',
+        const Visit(VisitKind.VISIT_UNRESOLVED_SET,
+                    name: 'o',
+                    rhs: '42')),
     const Test(
         '''
         var o;
         m() { o(null, 42); }
         ''',
         const Visit(VisitKind.VISIT_TOP_LEVEL_FIELD_INVOKE,
                     element: 'field(o)',
                     arguments: '(null,42)')),
     const Test.prefix(
         '''
@@ skipping 21 matching lines @@
                     element: 'getter(o)')),
     const Test.prefix(
         '''
         get o => null;
         ''',
         '''
         m() => p.o;
         ''',
         const Visit(VisitKind.VISIT_TOP_LEVEL_GETTER_GET,
                     element: 'getter(o)')),
+    // TODO(johnniwinther): Expect [VISIT_TOP_LEVEL_SETTER_GET] instead.
     const Test(
         '''
         set o(_) {}
+        m() => o;
+        ''',
+        const Visit(VisitKind.VISIT_UNRESOLVED_GET,
+                    name: 'o')),
+    const Test.prefix(
+        '''
+        set o(_) {}
+        ''',
+        '''
+        m() => p.o;
+        ''',
+        const Visit(VisitKind.VISIT_UNRESOLVED_GET,
+                    name: 'o')),
+    // TODO(johnniwinther): Expect [VISIT_TOP_LEVEL_GETTER_SET] instead.
+    const Test(
+        '''
+        get o => null;
+        m() { o = 42; }
+        ''',
+        const Visit(VisitKind.VISIT_UNRESOLVED_SET,
+                    name: 'o',
+                    rhs: '42')),
+    const Test.prefix(
+        '''
+        get o => null;
+        ''',
+        'm() { p.o = 42; }',
+        const Visit(VisitKind.VISIT_UNRESOLVED_SET,
+                    name: 'o',
+                    rhs: '42')),
+    const Test(
+        '''
+        set o(_) {}
         m() { o = 42; }
         ''',
         const Visit(VisitKind.VISIT_TOP_LEVEL_SETTER_SET,
                     element: 'setter(o)',
                     rhs: '42')),
     const Test.prefix(
         '''
         set o(_) {}
         ''',
         'm() { p.o = 42; }',
         const Visit(VisitKind.VISIT_TOP_LEVEL_SETTER_SET,
                     element: 'setter(o)',
                     rhs: '42')),
     const Test(
         '''
         get o => null;
         m() => o(null, 42);
         ''',
         const Visit(VisitKind.VISIT_TOP_LEVEL_GETTER_INVOKE,
                     element: 'getter(o)',
                     arguments: '(null,42)')),
     const Test.prefix(
         '''
         get o => null;
         ''',
         'm() { p.o(null, 42); }',
         const Visit(VisitKind.VISIT_TOP_LEVEL_GETTER_INVOKE,
                     element: 'getter(o)',
                     arguments: '(null,42)')),
+    // TODO(johnniwinther): Expected [VISIT_TOP_LEVEL_SETTER_INVOKE] instead.
+    const Test(
+        '''
+        set o(_) {}
+        m() => o(null, 42);
+        ''',
+        const Visit(VisitKind.VISIT_UNRESOLVED_INVOKE,
+                    name: 'o',
+                    arguments: '(null,42)')),
+    const Test.prefix(
+        '''
+        set o(_) {}
+        ''',
+        'm() { p.o(null, 42); }',
+        const Visit(VisitKind.VISIT_UNRESOLVED_INVOKE,
+                    name: 'o',
+                    arguments: '(null,42)')),
   ],
   'Top level functions': const [
     // Top level functions
     const Test(
         '''
         o(a, b) {}
         m() => o;
         ''',
         const Visit(VisitKind.VISIT_TOP_LEVEL_FUNCTION_GET,
                     element: 'function(o)')),
@@ skipping 21 matching lines @@
         const Visit(VisitKind.VISIT_TOP_LEVEL_FUNCTION_INVOKE,
                     element: 'function(o)',
                     arguments: '(null,42)')),
     const Test(
         '''
         m() => o(null, 42);
         ''',
         const Visit(VisitKind.VISIT_UNRESOLVED_INVOKE,
                     name: 'o',
                     arguments: '(null,42)')),
+    // TODO(johnniwinther): Expect [VISIT_TOP_LEVEL_FUNCTION_SET] instead.
+    const Test(
+        '''
+        o(a, b) {}
+        m() { o = 42; }
+        ''',
+        const Visit(VisitKind.VISIT_UNRESOLVED_SET,
+                    name: 'o',
+                    rhs: '42')),
+    const Test.prefix(
+        '''
+        o(a, b) {}
+        ''',
+        'm() { p.o = 42; }',
+        const Visit(VisitKind.VISIT_UNRESOLVED_SET,
+                    name: 'o',
+                    rhs: '42')),
   ],
   'Dynamic properties': const [
     // Dynamic properties
     const Test('m(o) => o.foo;',
         const [
           const Visit(VisitKind.VISIT_DYNAMIC_PROPERTY_GET,
                       receiver: 'o',
                       name: 'foo'),
           const Visit(VisitKind.VISIT_PARAMETER_GET,
                       element: 'parameter(m#o)'),
@@ skipping 153 matching lines @@
         class B {
           var o;
         }
         class C extends B {
           m() { super.o = 42; }
         }
         ''',
         const Visit(VisitKind.VISIT_SUPER_FIELD_SET,
                     element: 'field(B#o)',
                     rhs: '42')),
+    // TODO(johnniwinther): Expect [VISIT_FINAL_SUPER_FIELD_SET] instead.
+    const Test.clazz(
+        '''
+        class B {
+          final o = 0;
+        }
+        class C extends B {
+          m() { super.o = 42; }
+        }
+        ''',
+        const Visit(VisitKind.VISIT_UNRESOLVED_SET,
+                    name: 'o',
+                    rhs: '42')),
     const Test.clazz(
         '''
         class B {
           var o;
         }
         class C extends B {
           m() { super.o(null, 42); }
         }
         ''',
         const Visit(VisitKind.VISIT_SUPER_FIELD_INVOKE,
@@ skipping 15 matching lines @@
         '''
         class B {
           get o => null;
         }
         class C extends B {
           m() => super.o;
         }
         ''',
         const Visit(VisitKind.VISIT_SUPER_GETTER_GET,
                     element: 'getter(B#o)')),
+    // TODO(johnniwinther): Expect [VISIT_SUPER_SETTER_GET] instead.
     const Test.clazz(
         '''
         class B {
+          set o(_) {}
+        }
+        class C extends B {
+          m() => super.o;
+        }
+        ''',
+        const Visit(VisitKind.VISIT_UNRESOLVED_SUPER_GET)),
+    // TODO(johnniwinther): Expect [VISIT_SUPER_GETTER_SET] instead.
+    const Test.clazz(
+        '''
+        class B {
+          get o => 0;
+        }
+        class C extends B {
+          m() { super.o = 42; }
+        }
+        ''',
+        const Visit(VisitKind.VISIT_UNRESOLVED_SET,
+                    name: 'o',
+                    rhs: '42')),
+    const Test.clazz(
+        '''
+        class B {
           set o(_) {}
         }
         class C extends B {
           m() { super.o = 42; }
         }
         ''',
         const Visit(VisitKind.VISIT_SUPER_SETTER_SET,
                     element: 'setter(B#o)',
                     rhs: '42')),
     const Test.clazz(
         '''
         class B {
           get o => null;
         }
         class C extends B {
           m() { super.o(null, 42); }
         }
         ''',
         const Visit(VisitKind.VISIT_SUPER_GETTER_INVOKE,
                     element: 'getter(B#o)',
                     arguments: '(null,42)')),
+    // TODO(johnniwinther): Expect [VISIT_SUPER_SETTER_INVOKE] instead.
+    const Test.clazz(
+        '''
+        class B {
+          set o(_) {}
+        }
+        class C extends B {
+          m() { super.o(null, 42); }
+        }
+        ''',
+        const Visit(VisitKind.VISIT_UNRESOLVED_SUPER_INVOKE,
+                    arguments: '(null,42)')),
   ],
   'Super methods': const [
     // Super methods
     const Test.clazz(
         '''
         class B {
           o(a, b) {}
         }
         class C extends B {
           m() => super.o;
@@ skipping 2960 matching lines @@
   VisitKind.VISIT_SUPER_FIELD_FIELD_PREFIX,
   VisitKind.VISIT_SUPER_FIELD_FIELD_POSTFIX,
   VisitKind.VISIT_SUPER_METHOD_SETTER_COMPOUND,
   VisitKind.VISIT_SUPER_METHOD_SETTER_PREFIX,
   VisitKind.VISIT_SUPER_METHOD_SETTER_POSTFIX,
   VisitKind.VISIT_SUPER_NOT_EQUALS,
   VisitKind.VISIT_CLASS_TYPE_LITERAL_SET,
   VisitKind.VISIT_TYPEDEF_TYPE_LITERAL_SET,
   VisitKind.VISIT_TYPE_VARIABLE_TYPE_LITERAL_SET,
   VisitKind.VISIT_DYNAMIC_TYPE_LITERAL_SET,
+  VisitKind.VISIT_FINAL_PARAMETER_SET,
+  VisitKind.VISIT_FINAL_LOCAL_VARIABLE_SET,
+  VisitKind.VISIT_LOCAL_FUNCTION_SET,
+  VisitKind.VISIT_STATIC_GETTER_SET,
+  VisitKind.VISIT_STATIC_SETTER_GET,
+  VisitKind.VISIT_STATIC_SETTER_INVOKE,
+  VisitKind.VISIT_FINAL_STATIC_FIELD_SET,
+  VisitKind.VISIT_STATIC_FUNCTION_SET,
+  VisitKind.VISIT_FINAL_TOP_LEVEL_FIELD_SET,
+  VisitKind.VISIT_TOP_LEVEL_GETTER_SET,
+  VisitKind.VISIT_TOP_LEVEL_SETTER_GET,
+  VisitKind.VISIT_TOP_LEVEL_SETTER_INVOKE,
+  VisitKind.VISIT_TOP_LEVEL_FUNCTION_SET,
+  VisitKind.VISIT_FINAL_SUPER_FIELD_SET,
+  VisitKind.VISIT_SUPER_GETTER_SET,
+  VisitKind.VISIT_SUPER_SETTER_GET,
+  VisitKind.VISIT_SUPER_SETTER_INVOKE,
+  VisitKind.VISIT_SUPER_METHOD_SET,
 ];
 
 main(List<String> arguments) {
   Set<VisitKind> kinds = new Set<VisitKind>.from(VisitKind.values);
   asyncTest(() => Future.forEach([
     () {
       return test(
           kinds,
           arguments,
           SEND_TESTS,
@@ skipping 199 matching lines @@
       ConstantExpression constant,
       NodeList arguments,
       CallStructure callStructure,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_CLASS_TYPE_LITERAL_INVOKE,
         constant: constant.getText(), arguments: arguments));
     apply(arguments, arg);
   }
 
   @override
-  errorClassTypeLiteralSet(
+  visitClassTypeLiteralSet(
       SendSet node,
       ConstantExpression constant,
       Node rhs,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_CLASS_TYPE_LITERAL_INVOKE,
         constant: constant.getText(), rhs: rhs));
-    apply(rhs, arg);
+    super.visitClassTypeLiteralSet(node, constant, rhs, arg);
   }
 
   @override
   visitNotEquals(
       Send node,
       Node left,
       Node right,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_NOT_EQUALS,
         left: left, right: right));
@@ skipping 79 matching lines @@
       Send node,
       ConstantExpression constant,
       NodeList arguments,
       CallStructure callStructure,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_DYNAMIC_TYPE_LITERAL_INVOKE,
         constant: constant.getText(), arguments: arguments));
   }
 
   @override
-  errorDynamicTypeLiteralSet(
+  visitDynamicTypeLiteralSet(
       Send node,
       ConstantExpression constant,
       Node rhs,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_DYNAMIC_TYPE_LITERAL_SET,
         rhs: rhs));
-    apply(rhs, arg);
+    super.visitDynamicTypeLiteralSet(node, constant, rhs, arg);

[Johnni Winther, 2015/05/22 11:46:02]

Changed to test the implementation of TraversalSendMixin which should do the
same.

Done though-out the file but only where I touch the code anyway.

   }
 
   @override
   visitExpressionInvoke(
       Send node,
       Node expression,
       NodeList arguments,
       Selector selector,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_EXPRESSION_INVOKE,
@@ skipping 49 matching lines @@
   @override
   visitLocalFunctionGet(
       Send node,
       LocalFunctionElement function,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_LOCAL_FUNCTION_GET,
                          element: function));
   }
 
   @override
+  visitLocalFunctionSet(
+      SendSet node,
+      LocalFunctionElement function,
+      Node rhs,
+      arg) {
+    visits.add(new Visit(VisitKind.VISIT_LOCAL_FUNCTION_SET,
+        element: function, rhs: rhs));
+    super.visitLocalFunctionSet(node, function, rhs, arg);
+  }
+
+  @override
   visitLocalFunctionInvoke(
       Send node,
       LocalFunctionElement function,
       NodeList arguments,
       CallStructure callStructure,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_LOCAL_FUNCTION_INVOKE,
         element: function, arguments: arguments, selector: callStructure));
     apply(arguments, arg);
   }
@@ skipping 20 matching lines @@
   }
 
   @override
   visitLocalVariableSet(
       SendSet node,
       LocalVariableElement variable,
       Node rhs,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_LOCAL_VARIABLE_SET,
         element: variable, rhs: rhs));
-    apply(rhs, arg);
+    super.visitLocalVariableSet(node, variable, rhs, arg);
   }
 
   @override
+  visitFinalLocalVariableSet(
+      SendSet node,
+      LocalVariableElement variable,
+      Node rhs,
+      arg) {
+    visits.add(new Visit(VisitKind.VISIT_FINAL_LOCAL_VARIABLE_SET,
+        element: variable, rhs: rhs));
+    super.visitFinalLocalVariableSet(node, variable, rhs, arg);
+  }
+
+  @override
   visitParameterGet(
       Send node,
       ParameterElement parameter,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_PARAMETER_GET, element: parameter));
   }
 
   @override
   visitParameterInvoke(
       Send node,
       ParameterElement parameter,
       NodeList arguments,
       CallStructure callStructure,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_PARAMETER_INVOKE,
         element: parameter, arguments: arguments, selector: callStructure));
     apply(arguments, arg);
   }
 
   @override
   visitParameterSet(
       SendSet node,
       ParameterElement parameter,
       Node rhs,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_PARAMETER_SET,
                          element: parameter, rhs: rhs));
-    apply(rhs, arg);
+    super.visitParameterSet(node, parameter, rhs, arg);
   }
 
   @override
+  visitFinalParameterSet(
+      SendSet node,
+      ParameterElement parameter,
+      Node rhs,
+      arg) {
+    visits.add(new Visit(VisitKind.VISIT_FINAL_PARAMETER_SET,
+                         element: parameter, rhs: rhs));
+    super.visitFinalParameterSet(node, parameter, rhs, arg);
+  }
+
+  @override
   visitStaticFieldGet(
       Send node,
       FieldElement field,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_STATIC_FIELD_GET, element: field));
   }
 
   @override
   visitStaticFieldInvoke(
       Send node,
       FieldElement field,
       NodeList arguments,
       CallStructure callStructure,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_STATIC_FIELD_INVOKE,
         element: field, arguments: arguments));
     apply(arguments, arg);
   }
 
   @override
   visitStaticFieldSet(
       SendSet node,
       FieldElement field,
       Node rhs,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_STATIC_FIELD_SET,
         element: field, rhs: rhs));
-    apply(rhs, arg);
+    super.visitStaticFieldSet(node, field, rhs, arg);
   }
 
   @override
+  visitFinalStaticFieldSet(
+      SendSet node,
+      FieldElement field,
+      Node rhs,
+      arg) {
+    visits.add(new Visit(VisitKind.VISIT_FINAL_STATIC_FIELD_SET,
+        element: field, rhs: rhs));
+    super.visitFinalStaticFieldSet(node, field, rhs, arg);
+  }
+
+  @override
   visitStaticFunctionGet(
       Send node,
       MethodElement function,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_STATIC_FUNCTION_GET,
         element: function));
   }
 
   @override
+  visitStaticFunctionSet(
+      SendSet node,
+      MethodElement function,
+      Node rhs,
+      arg) {
+    visits.add(new Visit(VisitKind.VISIT_STATIC_FUNCTION_SET,
+        element: function, rhs: rhs));
+    super.visitStaticFunctionSet(node, function, rhs, arg);
+  }
+
+  @override
   visitStaticFunctionInvoke(
       Send node,
       MethodElement function,
       NodeList arguments,
       CallStructure callStructure,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_STATIC_FUNCTION_INVOKE,
         element: function, arguments: arguments));
-    apply(arguments, arg);
+    super.visitStaticFunctionInvoke(
+        node, function, arguments, callStructure, arg);
   }
 
   @override
   visitStaticFunctionIncompatibleInvoke(
       Send node,
       MethodElement function,
       NodeList arguments,
       CallStructure callStructure,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_STATIC_FUNCTION_INCOMPATIBLE_INVOKE,
         element: function, arguments: arguments));
     apply(arguments, arg);
   }
 
   @override
   visitStaticGetterGet(
       Send node,
       FunctionElement getter,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_STATIC_GETTER_GET,
         element: getter));
+    super.visitStaticGetterGet(node, getter, arg);
   }
 
   @override
+  visitStaticGetterSet(
+      SendSet node,
+      MethodElement getter,
+      Node rhs,
+      arg) {
+    visits.add(new Visit(VisitKind.VISIT_STATIC_GETTER_SET,
+        element: getter, rhs: rhs));
+    super.visitStaticGetterSet(node, getter, rhs, arg);
+  }
+
+  @override
   visitStaticGetterInvoke(
       Send node,
       FunctionElement getter,
       NodeList arguments,
       CallStructure callStructure,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_STATIC_GETTER_INVOKE,
         element: getter, arguments: arguments));
-    apply(arguments, arg);
+    super.visitStaticGetterInvoke(node, getter, arguments, callStructure, arg);
   }
 
   @override
+  visitStaticSetterInvoke(
+      Send node,
+      FunctionElement setter,
+      NodeList arguments,
+      CallStructure callStructure,
+      arg) {
+    visits.add(new Visit(VisitKind.VISIT_STATIC_SETTER_INVOKE,
+        element: setter, arguments: arguments));
+    super.visitStaticSetterInvoke(node, setter, arguments, callStructure, arg);
+  }
+
+  @override
+  visitStaticSetterGet(
+      Send node,
+      FunctionElement getter,
+      arg) {
+    visits.add(new Visit(VisitKind.VISIT_STATIC_SETTER_GET,
+        element: getter));
+    super.visitStaticSetterGet(node, getter, arg);
+  }
+
+  @override
   visitStaticSetterSet(
       SendSet node,
       FunctionElement setter,
       Node rhs,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_STATIC_SETTER_SET,
         element: setter, rhs: rhs));
-    apply(rhs, arg);
+    super.visitStaticSetterSet(node, setter, rhs, arg);
   }
 
   @override
   visitSuperBinary(
       Send node,
       FunctionElement function,
       BinaryOperator operator,
       Node argument,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_SUPER_BINARY,
@@ skipping 113 matching lines @@
   }
 
   @override
   visitTopLevelFieldSet(
       SendSet node,
       FieldElement field,
       Node rhs,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_TOP_LEVEL_FIELD_SET,
         element: field, rhs: rhs));
-    apply(rhs, arg);
+    super.visitTopLevelFieldSet(node, field, rhs, arg);
   }
 
   @override
+  visitFinalTopLevelFieldSet(
+      SendSet node,
+      FieldElement field,
+      Node rhs,
+      arg) {
+    visits.add(new Visit(VisitKind.VISIT_FINAL_TOP_LEVEL_FIELD_SET,
+        element: field, rhs: rhs));
+    super.visitFinalTopLevelFieldSet(node, field, rhs, arg);
+  }
+
+  @override
   visitTopLevelFunctionGet(
       Send node,
       MethodElement function,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_TOP_LEVEL_FUNCTION_GET,
         element: function));
   }
 
   @override
+  visitTopLevelFunctionSet(
+      SendSet node,
+      MethodElement function,
+      Node rhs,
+      arg) {
+    visits.add(new Visit(VisitKind.VISIT_TOP_LEVEL_FUNCTION_SET,
+        element: function, rhs: rhs));
+    super.visitTopLevelFunctionSet(node, function, rhs, arg);
+  }
+
+  @override
   visitTopLevelFunctionInvoke(
       Send node,
       MethodElement function,
       NodeList arguments,
       CallStructure callStructure,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_TOP_LEVEL_FUNCTION_INVOKE,
         element: function, arguments: arguments));
     apply(arguments, arg);
   }
@@ skipping 10 matching lines @@
     apply(arguments, arg);
   }
 
   @override
   visitTopLevelGetterGet(
       Send node,
       FunctionElement getter,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_TOP_LEVEL_GETTER_GET,
         element: getter));
+    super.visitTopLevelGetterGet(node, getter, arg);
   }
 
   @override
+  visitTopLevelSetterGet(
+      Send node,
+      FunctionElement setter,
+      arg) {
+    visits.add(new Visit(VisitKind.VISIT_TOP_LEVEL_SETTER_GET,
+        element: setter));
+    super.visitTopLevelSetterGet(node, setter, arg);
+  }
+
+  @override
   visitTopLevelGetterInvoke(
       Send node,
       FunctionElement getter,
       NodeList arguments,
       CallStructure callStructure,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_TOP_LEVEL_GETTER_INVOKE,
         element: getter, arguments: arguments));
-    apply(arguments, arg);
+    super.visitTopLevelGetterInvoke(
+        node, getter, arguments, callStructure, arg);
   }
 
   @override
+  visitTopLevelSetterInvoke(
+      Send node,
+      FunctionElement setter,
+      NodeList arguments,
+      CallStructure callStructure,
+      arg) {
+    visits.add(new Visit(VisitKind.VISIT_TOP_LEVEL_SETTER_INVOKE,
+        element: setter, arguments: arguments));
+    super.visitTopLevelSetterInvoke(
+        node, setter, arguments, callStructure, arg);
+  }
+
+  @override
+  visitTopLevelGetterSet(
+      SendSet node,
+      FunctionElement getter,
+      Node rhs,
+      arg) {
+    visits.add(new Visit(VisitKind.VISIT_TOP_LEVEL_GETTER_SET,
+        element: getter, rhs: rhs));
+    super.visitTopLevelGetterSet(node, getter, rhs, arg);
+  }
+
+  @override
   visitTopLevelSetterSet(
       SendSet node,
       FunctionElement setter,
       Node rhs,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_TOP_LEVEL_SETTER_SET,
         element: setter, rhs: rhs));
-    apply(rhs, arg);
+    super.visitTopLevelSetterSet(node, setter, rhs, arg);
   }
 
   @override
   visitTypeVariableTypeLiteralGet(
       Send node,
       TypeVariableElement element,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_TYPE_VARIABLE_TYPE_LITERAL_GET,
         element: element));
   }
 
   @override
   visitTypeVariableTypeLiteralInvoke(
       Send node,
       TypeVariableElement element,
       NodeList arguments,
       CallStructure callStructure,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_TYPE_VARIABLE_TYPE_LITERAL_INVOKE,
         element: element, arguments: arguments));
     apply(arguments, arg);
   }
 
   @override
-  errorTypeVariableTypeLiteralSet(
+  visitTypeVariableTypeLiteralSet(
       SendSet node,
       TypeVariableElement element,
       Node rhs,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_TYPE_VARIABLE_TYPE_LITERAL_SET,
         element: element, rhs: rhs));
-    apply(rhs, arg);
+    super.visitTypeVariableTypeLiteralSet(node, element, rhs, arg);
   }
 
   @override
   visitTypedefTypeLiteralGet(
       Send node,
       ConstantExpression constant,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_TYPEDEF_TYPE_LITERAL_GET,
         constant: constant.getText()));
   }
 
   @override
   visitTypedefTypeLiteralInvoke(
       Send node,
       ConstantExpression constant,
       NodeList arguments,
       CallStructure callStructure,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_TYPEDEF_TYPE_LITERAL_INVOKE,
         constant: constant.getText(), arguments: arguments));
     apply(arguments, arg);
   }
 
   @override
-  errorTypedefTypeLiteralSet(
+  visitTypedefTypeLiteralSet(
       SendSet node,
       ConstantExpression constant,
       Node rhs,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_TYPEDEF_TYPE_LITERAL_SET,
         constant: constant.getText(), rhs: rhs));
-    apply(rhs, arg);
+    super.visitTypedefTypeLiteralSet(node, constant, rhs, arg);
   }
 
   @override
   visitUnary(
       Send node,
       UnaryOperator operator,
       Node expression,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_UNARY,
         expression: expression, operator: operator));
@@ skipping 50 matching lines @@
   }
 
   @override
   visitSuperFieldSet(
       SendSet node,
       FieldElement field,
       Node rhs,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_SUPER_FIELD_SET,
         element: field, rhs: rhs));
-    apply(rhs, arg);
+    super.visitSuperFieldSet(node, field, rhs, arg);
   }
 
   @override
+  visitFinalSuperFieldSet(
+      SendSet node,
+      FieldElement field,
+      Node rhs,
+      arg) {
+    visits.add(new Visit(VisitKind.VISIT_FINAL_SUPER_FIELD_SET,
+        element: field, rhs: rhs));
+    super.visitFinalSuperFieldSet(node, field, rhs, arg);
+  }
+
+  @override
   visitSuperMethodGet(
       Send node,
       MethodElement method,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_SUPER_METHOD_GET, element: method));
   }
 
   @override
+  visitSuperMethodSet(
+      SendSet node,
+      MethodElement method,
+      Node rhs,
+      arg) {
+    visits.add(new Visit(VisitKind.VISIT_SUPER_METHOD_SET,
+        element: method, rhs: rhs));
+    super.visitSuperMethodSet(node, method, rhs, arg);
+  }
+
+  @override
   visitSuperMethodInvoke(
       Send node,
       MethodElement method,
       NodeList arguments,
       CallStructure callStructure,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_SUPER_METHOD_INVOKE,
         element: method, arguments: arguments));
     apply(arguments, arg);
   }
 
   @override
   visitSuperMethodIncompatibleInvoke(
       Send node,
       MethodElement method,
       NodeList arguments,
       CallStructure callStructure,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_SUPER_METHOD_INCOMPATIBLE_INVOKE,
         element: method, arguments: arguments));
     apply(arguments, arg);
   }
 
   @override
   visitSuperGetterGet(
       Send node,
       FunctionElement getter,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_SUPER_GETTER_GET, element: getter));
+    super.visitSuperGetterGet(node, getter, arg);
   }
 
   @override
+  visitSuperSetterGet(
+      Send node,
+      FunctionElement setter,
+      arg) {
+    visits.add(new Visit(VisitKind.VISIT_SUPER_SETTER_GET, element: setter));
+    super.visitSuperSetterGet(node, setter, arg);
+  }
+
+  @override
   visitSuperGetterInvoke(
       Send node,
       FunctionElement getter,
       NodeList arguments,
       CallStructure callStructure,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_SUPER_GETTER_INVOKE,
         element: getter, arguments: arguments));
-    apply(arguments, arg);
+    super.visitSuperGetterInvoke(node, getter, arguments, callStructure, arg);
   }
 
   @override
+  visitSuperSetterInvoke(
+      Send node,
+      FunctionElement setter,
+      NodeList arguments,
+      CallStructure callStructure,
+      arg) {
+    visits.add(new Visit(VisitKind.VISIT_SUPER_SETTER_INVOKE,
+        element: setter, arguments: arguments));
+    super.visitSuperSetterInvoke(node, setter, arguments, callStructure, arg);
+  }
+
+  @override
+  visitSuperGetterSet(
+      SendSet node,
+      FunctionElement getter,
+      Node rhs,
+      arg) {
+    visits.add(new Visit(VisitKind.VISIT_SUPER_GETTER_SET,
+        element: getter, rhs: rhs));
+    super.visitSuperGetterSet(node, getter, rhs, arg);
+  }
+
+  @override
   visitSuperSetterSet(
       SendSet node,
       FunctionElement setter,
       Node rhs,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_SUPER_SETTER_SET,
         element: setter, rhs: rhs));
-    apply(rhs, arg);
+    super.visitSuperSetterSet(node, setter, rhs, arg);
   }
 
   @override
   visitSuperUnary(
       Send node,
       UnaryOperator operator,
       FunctionElement function,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_SUPER_UNARY,
         element: function, operator: operator));
@@ skipping 1022 matching lines @@
 
   @override
   visitUnresolvedGet(
       Send node,
       Element element,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_UNRESOLVED_GET, name: element.name));
   }
 
   @override
+  visitUnresolvedSet(
+      Send node,
+      Element element,
+      Node rhs,
+      arg) {
+    visits.add(new Visit(VisitKind.VISIT_UNRESOLVED_SET,
+                         name: element.name, rhs: rhs));
+    super.visitUnresolvedSet(node, element, rhs, arg);
+  }
+
+  @override
   visitUnresolvedInvoke(
       Send node,
       Element element,
       NodeList arguments,
       Selector selector,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_UNRESOLVED_INVOKE,
-        name: element.name, arguments: arguments));
+                         name: element.name, arguments: arguments));
+    super.visitUnresolvedInvoke(node, element, arguments, selector, arg);
   }
 
   @override
   visitUnresolvedPostfix(
       Send node,
       ErroneousElement element,
       IncDecOperator operator,
       arg) {
     visits.add(new Visit(
         VisitKind.VISIT_UNRESOLVED_POSTFIX, operator: operator));
@@ skipping 1225 matching lines @@
   }
 }
 
 enum VisitKind {
   VISIT_PARAMETER_GET,
   VISIT_PARAMETER_SET,
   VISIT_PARAMETER_INVOKE,
   VISIT_PARAMETER_COMPOUND,
   VISIT_PARAMETER_PREFIX,
   VISIT_PARAMETER_POSTFIX,
+  VISIT_FINAL_PARAMETER_SET,
   VISIT_FINAL_PARAMETER_COMPOUND,
   VISIT_FINAL_PARAMETER_PREFIX,
   VISIT_FINAL_PARAMETER_POSTFIX,
 
   VISIT_LOCAL_VARIABLE_GET,
   VISIT_LOCAL_VARIABLE_SET,
   VISIT_LOCAL_VARIABLE_INVOKE,
   VISIT_LOCAL_VARIABLE_COMPOUND,
   VISIT_LOCAL_VARIABLE_PREFIX,
   VISIT_LOCAL_VARIABLE_POSTFIX,
   VISIT_LOCAL_VARIABLE_DECL,
   VISIT_LOCAL_CONSTANT_DECL,
+  VISIT_FINAL_LOCAL_VARIABLE_SET,
   VISIT_FINAL_LOCAL_VARIABLE_COMPOUND,
   VISIT_FINAL_LOCAL_VARIABLE_PREFIX,
   VISIT_FINAL_LOCAL_VARIABLE_POSTFIX,
 
   VISIT_LOCAL_FUNCTION_GET,
   VISIT_LOCAL_FUNCTION_INVOKE,
   VISIT_LOCAL_FUNCTION_DECL,
   VISIT_CLOSURE_DECL,
+  VISIT_LOCAL_FUNCTION_SET,
   VISIT_LOCAL_FUNCTION_COMPOUND,
   VISIT_LOCAL_FUNCTION_PREFIX,
   VISIT_LOCAL_FUNCTION_POSTFIX,
 
   VISIT_STATIC_FIELD_GET,
   VISIT_STATIC_FIELD_SET,
   VISIT_STATIC_FIELD_INVOKE,
   VISIT_STATIC_FIELD_COMPOUND,
   VISIT_STATIC_FIELD_PREFIX,
   VISIT_STATIC_FIELD_POSTFIX,
   VISIT_STATIC_FIELD_DECL,
   VISIT_STATIC_CONSTANT_DECL,
 
   VISIT_STATIC_GETTER_GET,
+  VISIT_STATIC_GETTER_SET,
+  VISIT_STATIC_GETTER_INVOKE,
+
+  VISIT_STATIC_SETTER_GET,
   VISIT_STATIC_SETTER_SET,
-  VISIT_STATIC_GETTER_INVOKE,
+  VISIT_STATIC_SETTER_INVOKE,
+
   VISIT_STATIC_GETTER_SETTER_COMPOUND,
   VISIT_STATIC_METHOD_SETTER_COMPOUND,
   VISIT_STATIC_GETTER_SETTER_PREFIX,
   VISIT_STATIC_GETTER_SETTER_POSTFIX,
+
   VISIT_STATIC_GETTER_DECL,
   VISIT_STATIC_SETTER_DECL,
+
+  VISIT_FINAL_STATIC_FIELD_SET,
   VISIT_STATIC_FINAL_FIELD_COMPOUND,
   VISIT_STATIC_FINAL_FIELD_POSTFIX,
   VISIT_STATIC_FINAL_FIELD_PREFIX,
 
   VISIT_STATIC_FUNCTION_GET,
+  VISIT_STATIC_FUNCTION_SET,
   VISIT_STATIC_FUNCTION_INVOKE,
   VISIT_STATIC_FUNCTION_INCOMPATIBLE_INVOKE,
   VISIT_STATIC_FUNCTION_DECL,
   VISIT_STATIC_METHOD_SETTER_PREFIX,
   VISIT_STATIC_METHOD_SETTER_POSTFIX,
 
   VISIT_UNRESOLVED_STATIC_GETTER_COMPOUND,
   VISIT_UNRESOLVED_STATIC_SETTER_COMPOUND,
   VISIT_STATIC_METHOD_COMPOUND,
   VISIT_UNRESOLVED_STATIC_GETTER_PREFIX,
   VISIT_UNRESOLVED_STATIC_SETTER_PREFIX,
   VISIT_STATIC_METHOD_PREFIX,
   VISIT_UNRESOLVED_STATIC_GETTER_POSTFIX,
   VISIT_UNRESOLVED_STATIC_SETTER_POSTFIX,
   VISIT_STATIC_METHOD_POSTFIX,
 
   VISIT_TOP_LEVEL_FIELD_GET,
   VISIT_TOP_LEVEL_FIELD_SET,
   VISIT_TOP_LEVEL_FIELD_INVOKE,
+  VISIT_FINAL_TOP_LEVEL_FIELD_SET,
   VISIT_TOP_LEVEL_FIELD_COMPOUND,
   VISIT_TOP_LEVEL_FIELD_PREFIX,
   VISIT_TOP_LEVEL_FIELD_POSTFIX,
   VISIT_TOP_LEVEL_FIELD_DECL,
   VISIT_TOP_LEVEL_CONSTANT_DECL,
   VISIT_TOP_LEVEL_FINAL_FIELD_COMPOUND,
   VISIT_TOP_LEVEL_FINAL_FIELD_POSTFIX,
   VISIT_TOP_LEVEL_FINAL_FIELD_PREFIX,
 
   VISIT_TOP_LEVEL_GETTER_GET,
+  VISIT_TOP_LEVEL_GETTER_SET,
+  VISIT_TOP_LEVEL_GETTER_INVOKE,
+  VISIT_TOP_LEVEL_SETTER_GET,
   VISIT_TOP_LEVEL_SETTER_SET,
-  VISIT_TOP_LEVEL_GETTER_INVOKE,
+  VISIT_TOP_LEVEL_SETTER_INVOKE,
   VISIT_TOP_LEVEL_GETTER_SETTER_COMPOUND,
   VISIT_TOP_LEVEL_GETTER_SETTER_PREFIX,
   VISIT_TOP_LEVEL_GETTER_SETTER_POSTFIX,
   VISIT_TOP_LEVEL_GETTER_DECL,
   VISIT_TOP_LEVEL_SETTER_DECL,
 
   VISIT_TOP_LEVEL_FUNCTION_GET,
+  VISIT_TOP_LEVEL_FUNCTION_SET,
   VISIT_TOP_LEVEL_FUNCTION_INVOKE,
   VISIT_TOP_LEVEL_FUNCTION_INCOMPATIBLE_INVOKE,
   VISIT_TOP_LEVEL_FUNCTION_DECL,
   VISIT_TOP_LEVEL_METHOD_SETTER_COMPOUND,
   VISIT_TOP_LEVEL_METHOD_SETTER_PREFIX,
   VISIT_TOP_LEVEL_METHOD_SETTER_POSTFIX,
 
   VISIT_UNRESOLVED_TOP_LEVEL_GETTER_COMPOUND,
   VISIT_UNRESOLVED_TOP_LEVEL_SETTER_COMPOUND,
   VISIT_TOP_LEVEL_METHOD_COMPOUND,
@@ skipping 16 matching lines @@
 
   VISIT_THIS_PROPERTY_GET,
   VISIT_THIS_PROPERTY_SET,
   VISIT_THIS_PROPERTY_INVOKE,
   VISIT_THIS_PROPERTY_COMPOUND,
   VISIT_THIS_PROPERTY_PREFIX,
   VISIT_THIS_PROPERTY_POSTFIX,
 
   VISIT_SUPER_FIELD_GET,
   VISIT_SUPER_FIELD_SET,
+  VISIT_FINAL_SUPER_FIELD_SET,
   VISIT_SUPER_FIELD_INVOKE,
   VISIT_SUPER_FIELD_COMPOUND,
   VISIT_SUPER_FIELD_PREFIX,
   VISIT_SUPER_FIELD_POSTFIX,
   VISIT_SUPER_FINAL_FIELD_COMPOUND,
   VISIT_SUPER_FINAL_FIELD_PREFIX,
   VISIT_SUPER_FINAL_FIELD_POSTFIX,
   VISIT_SUPER_FIELD_FIELD_COMPOUND,
   VISIT_SUPER_FIELD_FIELD_PREFIX,
   VISIT_SUPER_FIELD_FIELD_POSTFIX,
 
   VISIT_SUPER_GETTER_GET,
+  VISIT_SUPER_GETTER_SET,
+  VISIT_SUPER_GETTER_INVOKE,
+  VISIT_SUPER_SETTER_GET,
   VISIT_SUPER_SETTER_SET,
-  VISIT_SUPER_GETTER_INVOKE,
+  VISIT_SUPER_SETTER_INVOKE,
   VISIT_SUPER_GETTER_SETTER_COMPOUND,
   VISIT_SUPER_GETTER_FIELD_COMPOUND,
   VISIT_SUPER_FIELD_SETTER_COMPOUND,
   VISIT_SUPER_GETTER_SETTER_PREFIX,
   VISIT_SUPER_GETTER_FIELD_PREFIX,
   VISIT_SUPER_FIELD_SETTER_PREFIX,
   VISIT_SUPER_GETTER_SETTER_POSTFIX,
   VISIT_SUPER_GETTER_FIELD_POSTFIX,
   VISIT_SUPER_FIELD_SETTER_POSTFIX,
 
   VISIT_SUPER_METHOD_GET,
+  VISIT_SUPER_METHOD_SET,
   VISIT_SUPER_METHOD_INVOKE,
   VISIT_SUPER_METHOD_INCOMPATIBLE_INVOKE,
   VISIT_SUPER_METHOD_SETTER_COMPOUND,
   VISIT_SUPER_METHOD_SETTER_PREFIX,
   VISIT_SUPER_METHOD_SETTER_POSTFIX,
   VISIT_SUPER_METHOD_COMPOUND,
   VISIT_SUPER_METHOD_PREFIX,
   VISIT_SUPER_METHOD_POSTFIX,
 
   VISIT_UNRESOLVED_GET,
+  VISIT_UNRESOLVED_SET,
   VISIT_UNRESOLVED_INVOKE,
   VISIT_UNRESOLVED_SUPER_GET,
   VISIT_UNRESOLVED_SUPER_INVOKE,
 
   VISIT_BINARY,
   VISIT_INDEX,
   VISIT_EQUALS,
   VISIT_NOT_EQUALS,
   VISIT_INDEX_PREFIX,
   VISIT_INDEX_POSTFIX,
@@ skipping 108 matching lines @@
   VISIT_REQUIRED_INITIALIZING_FORMAL_DECL,
   VISIT_OPTIONAL_INITIALIZING_FORMAL_DECL,
   VISIT_NAMED_INITIALIZING_FORMAL_DECL,
 
   VISIT_UNRESOLVED_COMPOUND,
   VISIT_UNRESOLVED_PREFIX,
   VISIT_UNRESOLVED_POSTFIX,
 
   // TODO(johnniwinther): Add tests for more error cases.
 }