Change more JS foreign methods to JS_GET_NAME.

Change more JS foreign methods to JS_GET_NAME.

R=herhut@google.com

Committed: https://github.com/dart-lang/sdk/commit/683743c9c5b962acf5a062e8af31e27b0253ecc7

[herhut, 2015-06-03 08:58:29]

LGTM w/ some formatting comments :)

https://codereview.chromium.org/1154073004/diff/1/sdk/lib/_internal/compiler/...
File sdk/lib/_internal/compiler/js_lib/js_helper.dart (right):

https://codereview.chromium.org/1154073004/diff/1/sdk/lib/_internal/compiler/...
sdk/lib/_internal/compiler/js_lib/js_helper.dart:2321: JS('', '#[#] = #',
prototype, JS_GET_NAME(JsGetName.SIGNATURE_NAME), signatureFunction);
Long line...

https://codereview.chromium.org/1154073004/diff/1/sdk/lib/_internal/compiler/...
sdk/lib/_internal/compiler/js_lib/js_helper.dart:3224: return JS('bool', '# in
#', JS_GET_NAME(JsGetName.SIGNATURE_NAME), interceptor)
Long line...

https://codereview.chromium.org/1154073004/diff/1/sdk/lib/_internal/compiler/...
sdk/lib/_internal/compiler/js_lib/js_helper.dart:3232: JS('', '#[#] = true',
result, JS_GET_NAME(JsGetName.FUNCTION_TYPE_VOID_RETURN_TAG));
Long line...

https://codereview.chromium.org/1154073004/diff/1/sdk/lib/_internal/compiler/...
sdk/lib/_internal/compiler/js_lib/js_helper.dart:3235: JS('', '#[#] = #',
result, JS_GET_NAME(JsGetName.FUNCTION_TYPE_RETURN_TYPE_TAG),
Long line...

https://codereview.chromium.org/1154073004/diff/1/sdk/lib/_internal/compiler/...
sdk/lib/_internal/compiler/js_lib/js_helper.dart:3240: JS('', '#[#] = #',
result, JS_GET_NAME(JsGetName.FUNCTION_TYPE_REQUIRED_PARAMETERS_TAG),
Long line...

https://codereview.chromium.org/1154073004/diff/1/sdk/lib/_internal/compiler/...
sdk/lib/_internal/compiler/js_lib/js_helper.dart:3245: JS('', '#[#] = #',
result, JS_GET_NAME(JsGetName.FUNCTION_TYPE_OPTIONAL_PARAMETERS_TAG),
Long line...

https://codereview.chromium.org/1154073004/diff/1/sdk/lib/_internal/compiler/...
sdk/lib/_internal/compiler/js_lib/js_helper.dart:3257: JS('', '#[#] = #',
result, JS_GET_NAME(JsGetName.FUNCTION_TYPE_NAMED_PARAMETERS_TAG),
Long line...

https://codereview.chromium.org/1154073004/diff/1/sdk/lib/_internal/compiler/...
File sdk/lib/_internal/compiler/js_lib/js_mirrors.dart (right):

https://codereview.chromium.org/1154073004/diff/1/sdk/lib/_internal/compiler/...
sdk/lib/_internal/compiler/js_lib/js_mirrors.dart:2634: return JS('bool', '# in
#', JS_GET_NAME(JsGetName.FUNCTION_TYPE_RETURN_TYPE_TAG), _typeData);
Long line...

https://codereview.chromium.org/1154073004/diff/1/sdk/lib/_internal/compiler/...
sdk/lib/_internal/compiler/js_lib/js_mirrors.dart:2637: return JS('', '#[#]',
_typeData, JS_GET_NAME(JsGetName.FUNCTION_TYPE_RETURN_TYPE_TAG));
Long line...

https://codereview.chromium.org/1154073004/diff/1/sdk/lib/_internal/compiler/...
sdk/lib/_internal/compiler/js_lib/js_mirrors.dart:2641: return JS('bool',
'!!#[#]', _typeData, JS_GET_NAME(JsGetName.FUNCTION_TYPE_VOID_RETURN_TAG));
Long line...

https://codereview.chromium.org/1154073004/diff/1/sdk/lib/_internal/compiler/...
sdk/lib/_internal/compiler/js_lib/js_mirrors.dart:2646:
JS_GET_NAME(JsGetName.FUNCTION_TYPE_REQUIRED_PARAMETERS_TAG), _typeData);
Long line...

https://codereview.chromium.org/1154073004/diff/1/sdk/lib/_internal/compiler/...
sdk/lib/_internal/compiler/js_lib/js_mirrors.dart:2650: _typeData,
JS_GET_NAME(JsGetName.FUNCTION_TYPE_REQUIRED_PARAMETERS_TAG));
Long line...

https://codereview.chromium.org/1154073004/diff/1/sdk/lib/_internal/compiler/...
sdk/lib/_internal/compiler/js_lib/js_mirrors.dart:2655:
JS_GET_NAME(JsGetName.FUNCTION_TYPE_OPTIONAL_PARAMETERS_TAG), _typeData);
Long line...

https://codereview.chromium.org/1154073004/diff/1/sdk/lib/_internal/compiler/...
sdk/lib/_internal/compiler/js_lib/js_mirrors.dart:2659: _typeData,
JS_GET_NAME(JsGetName.FUNCTION_TYPE_OPTIONAL_PARAMETERS_TAG));
Long line...

https://codereview.chromium.org/1154073004/diff/1/sdk/lib/_internal/compiler/...
sdk/lib/_internal/compiler/js_lib/js_mirrors.dart:2663: return JS('bool', '# in
#',
Long line...

https://codereview.chromium.org/1154073004/diff/1/sdk/lib/_internal/compiler/...
sdk/lib/_internal/compiler/js_lib/js_mirrors.dart:2668: _typeData,
JS_GET_NAME(JsGetName.FUNCTION_TYPE_NAMED_PARAMETERS_TAG));
Long line...

https://codereview.chromium.org/1154073004/diff/1/sdk/lib/_internal/compiler/...
File sdk/lib/_internal/compiler/js_lib/js_rti.dart (right):

https://codereview.chromium.org/1154073004/diff/1/sdk/lib/_internal/compiler/...
sdk/lib/_internal/compiler/js_lib/js_rti.dart:109: getField(target,
'${JS_GET_NAME(JsGetName.OPERATOR_AS_PREFIX)}$substitutionName');
Long line...

https://codereview.chromium.org/1154073004/diff/1/sdk/lib/_internal/compiler/...
sdk/lib/_internal/compiler/js_lib/js_rti.dart:395: var targetSignatureFunction =
getField(o, '${JS_GET_NAME(JsGetName.SIGNATURE_NAME)}');
Long line...

https://codereview.chromium.org/1154073004/diff/1/sdk/lib/_internal/compiler/...
sdk/lib/_internal/compiler/js_lib/js_rti.dart:462: var field =
'${JS_GET_NAME(JsGetName.OPERATOR_AS_PREFIX)}${runtimeTypeToString(typeOfT)}';
Long line...

https://codereview.chromium.org/1154073004/diff/1/sdk/lib/_internal/compiler/...
sdk/lib/_internal/compiler/js_lib/js_rti.dart:535: if (hasNoField(t,
'${JS_GET_NAME(JsGetName.FUNCTION_TYPE_VOID_RETURN_TAG)}') &&
Long line...

https://codereview.chromium.org/1154073004/diff/1/sdk/lib/_internal/compiler/...
sdk/lib/_internal/compiler/js_lib/js_rti.dart:536: hasField(t,
'${JS_GET_NAME(JsGetName.FUNCTION_TYPE_RETURN_TYPE_TAG)}')) {
Long line...

https://codereview.chromium.org/1154073004/diff/1/sdk/lib/_internal/compiler/...
sdk/lib/_internal/compiler/js_lib/js_rti.dart:539: } else if (hasNoField(t,
'${JS_GET_NAME(JsGetName.FUNCTION_TYPE_VOID_RETURN_TAG)}')) {
Long line...

https://codereview.chromium.org/1154073004/diff/1/sdk/lib/_internal/compiler/...
sdk/lib/_internal/compiler/js_lib/js_rti.dart:540: var sReturnType = getField(s,
'${JS_GET_NAME(JsGetName.FUNCTION_TYPE_RETURN_TYPE_TAG)}');
Long line...

https://codereview.chromium.org/1154073004/diff/1/sdk/lib/_internal/compiler/...
sdk/lib/_internal/compiler/js_lib/js_rti.dart:541: var tReturnType = getField(t,
'${JS_GET_NAME(JsGetName.FUNCTION_TYPE_RETURN_TYPE_TAG)}');
Long line...

https://codereview.chromium.org/1154073004/diff/1/sdk/lib/_internal/compiler/...
sdk/lib/_internal/compiler/js_lib/js_rti.dart:547: getField(t,
'${JS_GET_NAME(JsGetName.FUNCTION_TYPE_REQUIRED_PARAMETERS_TAG)}');
Long line...

https://codereview.chromium.org/1154073004/diff/1/sdk/lib/_internal/compiler/...
sdk/lib/_internal/compiler/js_lib/js_rti.dart:550: getField(s,
'${JS_GET_NAME(JsGetName.FUNCTION_TYPE_OPTIONAL_PARAMETERS_TAG)}');
Long line...

https://codereview.chromium.org/1154073004/diff/1/sdk/lib/_internal/compiler/...
sdk/lib/_internal/compiler/js_lib/js_rti.dart:552: getField(t,
'${JS_GET_NAME(JsGetName.FUNCTION_TYPE_OPTIONAL_PARAMETERS_TAG)}');
Long line...

https://codereview.chromium.org/1154073004/diff/1/sdk/lib/_internal/compiler/...
sdk/lib/_internal/compiler/js_lib/js_rti.dart:610: getField(s,
'${JS_GET_NAME(JsGetName.FUNCTION_TYPE_NAMED_PARAMETERS_TAG)}');
Long line...

https://codereview.chromium.org/1154073004/diff/1/sdk/lib/_internal/compiler/...
sdk/lib/_internal/compiler/js_lib/js_rti.dart:612: getField(t,
'${JS_GET_NAME(JsGetName.FUNCTION_TYPE_NAMED_PARAMETERS_TAG)}');
Long line...

[karlklose, 2015-06-03 09:39:03]

Sorry for the long lines :(

[karlklose, 2015-06-03 09:39:55]

Patchset #2 (id:20001) has been deleted

[karlklose, 2015-06-03 09:41:50]

Committed patchset #2 (id:40001) manually as
683743c9c5b962acf5a062e8af31e27b0253ecc7 (presubmit successful).