Change more JS foreign methods to JS_GET_NAME.

sdk/lib/_internal/compiler/js_lib/js_helper.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library _js_helper;
 
 import 'dart:_async_await_error_codes' as async_error_codes;
 
 import 'dart:_js_embedded_names' show
     DEFERRED_LIBRARY_URIS,
@@ skipping 2300 matching lines @@
         '',
         'function(f,r){'
           'return function(){'
             'return f.apply({\$receiver:r(this)},arguments)'
           '}'
         '}(#,#)', functionType, getReceiver);
     } else {
       throw 'Error in reflectionInfo.';
     }
 
-    JS('', '#[#] = #', prototype, JS_SIGNATURE_NAME(), signatureFunction);
+    JS('', '#[#] = #', prototype, JS_GET_NAME(JsGetName.SIGNATURE_NAME), signatureFunction);

[herhut, 2015/06/03 08:58:28]

Long line...

 
     JS('', '#[#] = #', prototype, callName, trampoline);
     for (int i = 1; i < functions.length; i++) {
       var stub = functions[i];
       var stubCallName = JS('String|Null', '#[#]', stub,
           JS_GET_NAME(JsGetName.CALL_NAME_PROPERTY));
       if (stubCallName != null) {
         JS('', '#[#] = #', prototype, stubCallName,
            isStatic ? stub : forwardCallTo(receiver, stub, isIntercepted));
       }
@@ skipping 882 matching lines @@
       }
       throw new CastErrorImplementation(pretty, self);
     } else {
       // TODO(ahe): Pass "pretty" function-type to TypeErrorImplementation?
       throw new TypeErrorImplementation(expression, self);
     }
   }
 
   _extractFunctionTypeObjectFrom(o) {
     var interceptor = getInterceptor(o);
-    return JS('bool', '# in #', JS_SIGNATURE_NAME(), interceptor)
-        ? JS('', '#[#]()', interceptor, JS_SIGNATURE_NAME())
+    return JS('bool', '# in #', JS_GET_NAME(JsGetName.SIGNATURE_NAME), interceptor)

[herhut, 2015/06/03 08:58:28]

Long line...

+        ? JS('', '#[#]()', interceptor, JS_GET_NAME(JsGetName.SIGNATURE_NAME))
         : null;
   }
 
   toRti() {
     var result = createDartFunctionTypeRti();
     if (isVoid) {
-      JS('', '#[#] = true', result, JS_FUNCTION_TYPE_VOID_RETURN_TAG());
+      JS('', '#[#] = true', result, JS_GET_NAME(JsGetName.FUNCTION_TYPE_VOID_RETURN_TAG));

[herhut, 2015/06/03 08:58:28]

Long line...

     } else {
       if (returnType is! DynamicRuntimeType) {
-        JS('', '#[#] = #', result, JS_FUNCTION_TYPE_RETURN_TYPE_TAG(),
+        JS('', '#[#] = #', result, JS_GET_NAME(JsGetName.FUNCTION_TYPE_RETURN_TYPE_TAG),

[herhut, 2015/06/03 08:58:28]

Long line...

            returnType.toRti());
       }
     }
     if (parameterTypes != null && !parameterTypes.isEmpty) {
-      JS('', '#[#] = #', result, JS_FUNCTION_TYPE_REQUIRED_PARAMETERS_TAG(),
+      JS('', '#[#] = #', result, JS_GET_NAME(JsGetName.FUNCTION_TYPE_REQUIRED_PARAMETERS_TAG),

[herhut, 2015/06/03 08:58:27]

Long line...

          listToRti(parameterTypes));
     }
 
     if (optionalParameterTypes != null && !optionalParameterTypes.isEmpty) {
-      JS('', '#[#] = #', result, JS_FUNCTION_TYPE_OPTIONAL_PARAMETERS_TAG(),
+      JS('', '#[#] = #', result, JS_GET_NAME(JsGetName.FUNCTION_TYPE_OPTIONAL_PARAMETERS_TAG),

[herhut, 2015/06/03 08:58:27]

Long line...

          listToRti(optionalParameterTypes));
     }
 
     if (namedParameters != null) {
       var namedRti = JS('=Object', 'Object.create(null)');
       var keys = extractKeys(namedParameters);
       for (var i = 0; i < keys.length; i++) {
         var name = keys[i];
         var rti = JS('', '#[#]', namedParameters, name).toRti();
         JS('', '#[#] = #', namedRti, name, rti);
       }
-      JS('', '#[#] = #', result, JS_FUNCTION_TYPE_NAMED_PARAMETERS_TAG(),
+      JS('', '#[#] = #', result, JS_GET_NAME(JsGetName.FUNCTION_TYPE_NAMED_PARAMETERS_TAG),

[herhut, 2015/06/03 08:58:27]

Long line...

          namedRti);
     }
 
     return result;
   }
 
   static listToRti(list) {
     list = JS('JSFixedArray', '#', list);
     var result = JS('JSExtendableArray', '[]');
     for (var i = 0; i < list.length; i++) {
@@ skipping 821 matching lines @@
   // This is a function that will return a helper function that does the
   // iteration of the sync*.
   //
   // Each invocation should give a body with fresh state.
   final dynamic /* js function */ _outerHelper;
 
   SyncStarIterable(this._outerHelper);
 
   Iterator get iterator => new SyncStarIterator(JS('', '#()', _outerHelper));
 }