Issue 11538007: Clean up the timer source in the isolate library to be less VM specific.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11538007: Clean up the timer source in the isolate library to be less VM specific. (Closed)

Created:
8 years ago by ngeoffray

Modified:
8 years ago

Reviewers:
ahe, Anders Johnsen, srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Clean up the timer source in the isolate library to be less VM specific. Committed: https://code.google.com/p/dart/source/detail?r=16024

Patch Set 2 : #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -40 lines)			Patch
M	runtime/lib/isolate_patch.dart	View		1 chunk	+34 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/isolate_patch.dart	View	1	3 chunks	+19 lines, -11 lines	0 comments	Download
M	sdk/lib/isolate/timer.dart	View		1 chunk	+3 lines, -29 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

LGTM https://codereview.chromium.org/11538007/diff/2001/runtime/lib/isolate_patch.dart File runtime/lib/isolate_patch.dart (right): https://codereview.chromium.org/11538007/diff/2001/runtime/lib/isolate_patch.dart#newcode161 runtime/lib/isolate_patch.dart:161: void _setTimerFactoryClosure(_TimerFactoryClosure closure) { Maybe check if we ...

8 years ago (2012-12-11 18:59:24 UTC) #3

ngeoffray

8 years ago (2012-12-12 08:31:12 UTC) #5

Thanks all.

https://codereview.chromium.org/11538007/diff/2001/runtime/lib/isolate_patch....
File runtime/lib/isolate_patch.dart (right):

https://codereview.chromium.org/11538007/diff/2001/runtime/lib/isolate_patch....
runtime/lib/isolate_patch.dart:161: void
_setTimerFactoryClosure(_TimerFactoryClosure closure) {
On 2012/12/11 18:59:24, Anders Johnsen wrote:
> Maybe check if we are still using this function.

Yes we do, in runtime/bin/dartutils.cc.

Expand Messages | Collapse Messages

Issue 11538007: Clean up the timer source in the isolate library to be less VM specific. (Closed)

Description

Patch Set 1 : #

Patch Set 2 : #

Messages