Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1392)

Unified Diff: sdk/lib/_internal/compiler/implementation/lib/isolate_patch.dart

Issue 11538007: Clean up the timer source in the isolate library to be less VM specific. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/isolate_patch.dart ('k') | sdk/lib/isolate/timer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/lib/isolate_patch.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/lib/isolate_patch.dart (revision 15985)
+++ sdk/lib/_internal/compiler/implementation/lib/isolate_patch.dart (working copy)
@@ -46,9 +46,6 @@
// by having a "default" isolate (the first one created).
_globalState.currentContext = rootContext;
- if (_window != null) {
- rootContext.eval(() => _setTimerFactoryClosure( _timerFactory));
- }
rootContext.eval(entry);
_globalState.topEventLoop.run();
}
@@ -575,11 +572,6 @@
_lazyPort = new ReceivePort();
replyTo.send(_SPAWNED_SIGNAL, port.toSendPort());
- if (_window != null) {
- _globalState.currentContext.eval(
- () => _setTimerFactoryClosure(_timerFactory));
- }
-
topLevel();
}
@@ -1285,6 +1277,22 @@
}
}
-Timer _timerFactory(int millis, void callback(Timer timer), bool repeating) =>
- repeating ? new _Timer.repeating(millis, callback)
- : new _Timer(millis, callback);
+patch class Timer {
+ patch factory Timer(int milliSeconds, void callback(Timer timer)) {
+ if (_window == null) {
+ throw new UnsupportedError("Timer interface not supported.");
+ }
+ return new _Timer(milliSeconds, callback);
+ }
+
+ /**
+ * Creates a new repeating timer. The [callback] is invoked every
+ * [milliSeconds] millisecond until cancelled.
+ */
+ patch factory Timer.repeating(int milliSeconds, void callback(Timer timer)) {
+ if (_window == null) {
+ throw new UnsupportedError("Timer interface not supported.");
+ }
+ return new _Timer.repeating(milliSeconds, callback);
+ }
+}
« no previous file with comments | « runtime/lib/isolate_patch.dart ('k') | sdk/lib/isolate/timer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698