Make analyzer DDC warning clean.

Make analyzer DDC warning clean.

R=brianwilkerson@google.com, vsm@google.com

Committed: https://github.com/dart-lang/sdk/commit/c9b672a6dd270fc67f6a8176c0b9be3f4994ff8e

[Paul Berry, 2015-05-30 13:04:46]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com, vsm@google.com

[Brian Wilkerson, 2015-05-30 15:52:57]

LGTM

https://codereview.chromium.org/1153503005/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/engine.dart (right):

https://codereview.chromium.org/1153503005/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/engine.dart:2509: bool
shouldErrorsBeAnalyzed(Source source, Object entry) {
I don't like this change, but I'm guessing that either the parameter can go away
or can be made more specific when we get rid of the old implementation of
AnalysisContext.

[vsm, 2015-06-01 13:48:45]

LGTM -nice!

https://codereview.chromium.org/1153503005/diff/1/pkg/analyzer/lib/src/contex...
File pkg/analyzer/lib/src/context/cache.dart (right):

https://codereview.chromium.org/1153503005/diff/1/pkg/analyzer/lib/src/contex...
pkg/analyzer/lib/src/context/cache.dart:161: List<Map<AnalysisTarget,
CacheEntry>> maps =
Consider dropping the type on the lhs side.  We'll infer in this case.

https://codereview.chromium.org/1153503005/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/engine.dart (right):

https://codereview.chromium.org/1153503005/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/engine.dart:170: List<Map<Source, SourceEntry>>
maps =
ditto here for lhs

https://codereview.chromium.org/1153503005/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/engine.dart:2509: bool
shouldErrorsBeAnalyzed(Source source, Object entry) {
On 2015/05/30 15:52:57, Brian Wilkerson wrote:
> I don't like this change, but I'm guessing that either the parameter can go
away
> or can be made more specific when we get rid of the old implementation of
> AnalysisContext.

Not sure it makes sense here, but an alternative is to change the base class
method's signature.

https://codereview.chromium.org/1153503005/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/engine.dart:2644: new
List<TimestampedData<CompilationUnit>>(parts.length + 1);
Here as well though perhaps it's your style to be explicit on the lhs?

Note, we'd also do left to right inference (here and elsewhere) if you had only:

List<TimestampedData<CompilationUnit>> units = new List(parts.length + 1);

We don't do the inference if the rhs InstanceCreationExpression already has a
template param.

[Paul Berry, 2015-06-01 15:38:14]

https://codereview.chromium.org/1153503005/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/engine.dart (right):

https://codereview.chromium.org/1153503005/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/engine.dart:2509: bool
shouldErrorsBeAnalyzed(Source source, Object entry) {
On 2015/05/30 15:52:57, Brian Wilkerson wrote:
> I don't like this change, but I'm guessing that either the parameter can go
away
> or can be made more specific when we get rid of the old implementation of
> AnalysisContext.

Acknowledged.

https://codereview.chromium.org/1153503005/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/engine.dart:2644: new
List<TimestampedData<CompilationUnit>>(parts.length + 1);
On 2015/06/01 13:48:45, vsm wrote:
> Here as well though perhaps it's your style to be explicit on the lhs?
> 
> Note, we'd also do left to right inference (here and elsewhere) if you had
only:
> 
> List<TimestampedData<CompilationUnit>> units = new List(parts.length + 1);
> 
> We don't do the inference if the rhs InstanceCreationExpression already has a
> template param.

This morning we had a discussion about this (and your other suggestions, which
parallel it).  Unfortunately, dropping the template parameter from List on the
RHS has the disadvantage of reducing the runtime checks performed by the VM;
conversely dropping the type from the LHS has the disadvantage of reducing the
static checks performed by analyzer.  Given that DDC is not yet integrated into
the analyzer toolchain, we'd like to stay verbose so that we keep all the
checks.  Once DDC is integrated into analyzer enough that we can have a buildbot
enforcing DDC's stricter type checks, we'll consider dropping the type from the
LHS.

[Paul Berry, 2015-06-01 15:54:15]

Committed patchset #1 (id:1) manually as
c9b672a6dd270fc67f6a8176c0b9be3f4994ff8e (presubmit successful).