Make analyzer DDC warning clean.

pkg/analyzer/lib/src/generated/engine.dart

Index: pkg/analyzer/lib/src/generated/engine.dart
diff --git a/pkg/analyzer/lib/src/generated/engine.dart b/pkg/analyzer/lib/src/generated/engine.dart
index 3650fc84f4295198d424794fc088b3e09902bf7c..dfbac68d7704ad0a05d529ea870652a3cbbc54d9 100644
--- a/pkg/analyzer/lib/src/generated/engine.dart
+++ b/pkg/analyzer/lib/src/generated/engine.dart
@@ -167,7 +167,8 @@ class AnalysisCache {
    */
   MapIterator<Source, SourceEntry> iterator() {
     int count = _partitions.length;
-    List<Map<Source, SourceEntry>> maps = new List<Map>(count);
+    List<Map<Source, SourceEntry>> maps =

[vsm, 2015/06/01 13:48:45]

ditto here for lhs

+        new List<Map<Source, SourceEntry>>(count);
     for (int i = 0; i < count; i++) {
       maps[i] = _partitions[i].map;
     }
@@ -2505,7 +2506,8 @@ class AnalysisContextImpl implements InternalAnalysisContext {
   }
 
   @override
-  bool shouldErrorsBeAnalyzed(Source source, DartEntry dartEntry) {
+  bool shouldErrorsBeAnalyzed(Source source, Object entry) {

[Brian Wilkerson, 2015/05/30 15:52:57]

I don't like this change, but I'm guessing that either the parameter can go away
or can be made more specific when we get rid of the old implementation of
AnalysisContext.

[vsm, 2015/06/01 13:48:45]

Not sure it makes sense here, but an alternative is to change the base class
method's signature.

[Paul Berry, 2015/06/01 15:38:14]

Acknowledged.

+    DartEntry dartEntry = entry;
     if (source.isInSystemLibrary) {
       return _generateSdkErrors;
     } else if (!dartEntry.explicitlyAdded) {
@@ -2639,7 +2641,7 @@ class AnalysisContextImpl implements InternalAnalysisContext {
           libraryElement.definingCompilationUnit;
       List<CompilationUnitElement> parts = libraryElement.parts;
       List<TimestampedData<CompilationUnit>> units =
-          new List<TimestampedData>(parts.length + 1);
+          new List<TimestampedData<CompilationUnit>>(parts.length + 1);

[vsm, 2015/06/01 13:48:45]

Here as well though perhaps it's your style to be explicit on the lhs?

Note, we'd also do left to right inference (here and elsewhere) if you had only:

List<TimestampedData<CompilationUnit>> units = new List(parts.length + 1);

We don't do the inference if the rhs InstanceCreationExpression already has a
template param.

[Paul Berry, 2015/06/01 15:38:14]

This morning we had a discussion about this (and your other suggestions, which
parallel it).  Unfortunately, dropping the template parameter from List on the
RHS has the disadvantage of reducing the runtime checks performed by the VM;
conversely dropping the type from the LHS has the disadvantage of reducing the
static checks performed by analyzer.  Given that DDC is not yet integrated into
the analyzer toolchain, we'd like to stay verbose so that we keep all the
checks.  Once DDC is integrated into analyzer enough that we can have a buildbot
enforcing DDC's stricter type checks, we'll consider dropping the type from the
LHS.

       units[0] = _getResolvedUnit(definingUnit, librarySource);
       if (units[0] == null) {
         Source source = definingUnit.source;
@@ -2693,7 +2695,7 @@ class AnalysisContextImpl implements InternalAnalysisContext {
           libraryElement.definingCompilationUnit;
       List<CompilationUnitElement> parts = libraryElement.parts;
       List<TimestampedData<CompilationUnit>> units =
-          new List<TimestampedData>(parts.length + 1);
+          new List<TimestampedData<CompilationUnit>>(parts.length + 1);
       units[0] = _getResolvedUnit(definingUnit, librarySource);
       if (units[0] == null) {
         Source source = definingUnit.source;
@@ -3099,7 +3101,7 @@ class AnalysisContextImpl implements InternalAnalysisContext {
         libraryElement.definingCompilationUnit;
     List<CompilationUnitElement> parts = libraryElement.parts;
     List<TimestampedData<CompilationUnit>> units =
-        new List<TimestampedData>(parts.length + 1);
+        new List<TimestampedData<CompilationUnit>>(parts.length + 1);
     units[0] = _getResolvedUnit(definingUnit, librarySource);
     if (units[0] == null) {
       // TODO(brianwilkerson) We should return a ResolveDartUnitTask
@@ -3132,7 +3134,7 @@ class AnalysisContextImpl implements InternalAnalysisContext {
         libraryElement.definingCompilationUnit;
     List<CompilationUnitElement> parts = libraryElement.parts;
     List<TimestampedData<CompilationUnit>> units =
-        new List<TimestampedData>(parts.length + 1);
+        new List<TimestampedData<CompilationUnit>>(parts.length + 1);
     units[0] = _getResolvedUnit(definingUnit, librarySource);
     if (units[0] == null) {
       // TODO(brianwilkerson) We should return a ResolveDartUnitTask
@@ -11501,7 +11503,7 @@ class WorkManager {
    */
   WorkManager() {
     int queueCount = SourcePriority.values.length;
-    _workQueues = new List<List>(queueCount);
+    _workQueues = new List<List<Source>>(queueCount);
     for (int i = 0; i < queueCount; i++) {
       _workQueues[i] = new List<Source>();
     }