Create SendStructure for unary and binary in resolution.

Create SendStructure for unary and binary in resolution.

BUG=http://dartbug.com/21137
R=karlklose@google.com

Committed: https://github.com/dart-lang/sdk/commit/45ec43770dd32725600cca8942f27893c094a540

[Johnni Winther, 2015-05-26 07:46:27]

johnniwinther@google.com changed reviewers:
+ karlklose@google.com

[karlklose, 2015-05-26 08:23:33]

LGTM.

https://codereview.chromium.org/1152903003/diff/1/pkg/compiler/lib/src/elemen...
File pkg/compiler/lib/src/elements/modelx.dart (right):

https://codereview.chromium.org/1152903003/diff/1/pkg/compiler/lib/src/elemen...
pkg/compiler/lib/src/elements/modelx.dart:2498: {bool isSuperLookup}) {
Fix indentation. Does it fit on one line now?

https://codereview.chromium.org/1152903003/diff/1/pkg/compiler/lib/src/inferr...
File pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart (right):

https://codereview.chromium.org/1152903003/diff/1/pkg/compiler/lib/src/inferr...
pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart:1420: return
handleSuperMethodInvoke(
Do we lose track of the ! here or does handleSuperMethodInvoke check for
operator!= vs. operator==?

https://codereview.chromium.org/1152903003/diff/1/pkg/compiler/lib/src/resolu...
File pkg/compiler/lib/src/resolution/members.dart (right):

https://codereview.chromium.org/1152903003/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/members.dart:2864:
registry.registerSuperUse(node);
Move this to after the checks?

https://codereview.chromium.org/1152903003/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/members.dart:2954: return null;
Not this change, but: I really do not like to return an explicit null value in
this visitor: it is the only value this method ever returns and it would be
neither to have a special constant to be able to catch errors, when we return
null by accident. Also, it would give us a place to document the semantics of
this special value.

https://codereview.chromium.org/1152903003/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/members.dart:2993: switch (semantics.kind) {
How about
 if (semantics.kind == AccessKind.SUPER_METHOD) 
   registry.registerStaticUse(semantics.element.declaration);
 }

and switch to 'switch' when we have more cases?

https://codereview.chromium.org/1152903003/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/members.dart:3078: switch (semantics.kind) {
See comment for l. 2993.

https://codereview.chromium.org/1152903003/diff/1/tests/co19/co19-dart2js.status
File tests/co19/co19-dart2js.status (right):

https://codereview.chromium.org/1152903003/diff/1/tests/co19/co19-dart2js.sta...
tests/co19/co19-dart2js.status:4217:
+WebPlatformTest/html/semantics/document-metadata/styling/LinkStyle_t01: Pass,
RuntimeError # Fails on 7.1. Please triage this failure
Is this a line-ending style change?

[Johnni Winther, 2015-05-26 08:53:11]

https://codereview.chromium.org/1152903003/diff/1/pkg/compiler/lib/src/elemen...
File pkg/compiler/lib/src/elements/modelx.dart (right):

https://codereview.chromium.org/1152903003/diff/1/pkg/compiler/lib/src/elemen...
pkg/compiler/lib/src/elements/modelx.dart:2498: {bool isSuperLookup}) {
On 2015/05/26 08:23:32, karlklose wrote:
> Fix indentation. Does it fit on one line now?

Done.

https://codereview.chromium.org/1152903003/diff/1/pkg/compiler/lib/src/inferr...
File pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart (right):

https://codereview.chromium.org/1152903003/diff/1/pkg/compiler/lib/src/inferr...
pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart:1420: return
handleSuperMethodInvoke(
On 2015/05/26 08:23:32, karlklose wrote:
> Do we lose track of the ! here or does handleSuperMethodInvoke check for
> operator!= vs. operator==?

I think we lose track in SuperEquals and SuperNotEquals. Adding a TODO.

https://codereview.chromium.org/1152903003/diff/1/pkg/compiler/lib/src/resolu...
File pkg/compiler/lib/src/resolution/members.dart (right):

https://codereview.chromium.org/1152903003/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/members.dart:2864:
registry.registerSuperUse(node);
On 2015/05/26 08:23:32, karlklose wrote:
> Move this to after the checks?

Done.

https://codereview.chromium.org/1152903003/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/members.dart:2954: return null;
On 2015/05/26 08:23:32, karlklose wrote:
> Not this change, but: I really do not like to return an explicit null value in
> this visitor: it is the only value this method ever returns and it would be
> neither to have a special constant to be able to catch errors, when we return
> null by accident. Also, it would give us a place to document the semantics of
> this special value.

Acknowledged.

https://codereview.chromium.org/1152903003/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/members.dart:2993: switch (semantics.kind) {
On 2015/05/26 08:23:32, karlklose wrote:
> How about
>  if (semantics.kind == AccessKind.SUPER_METHOD) 
>    registry.registerStaticUse(semantics.element.declaration);
>  }
> 
> and switch to 'switch' when we have more cases?

Done.

https://codereview.chromium.org/1152903003/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/members.dart:3078: switch (semantics.kind) {
On 2015/05/26 08:23:33, karlklose wrote:
> See comment for l. 2993.

Done.

https://codereview.chromium.org/1152903003/diff/1/tests/co19/co19-dart2js.status
File tests/co19/co19-dart2js.status (right):

https://codereview.chromium.org/1152903003/diff/1/tests/co19/co19-dart2js.sta...
tests/co19/co19-dart2js.status:4217:
+WebPlatformTest/html/semantics/document-metadata/styling/LinkStyle_t01: Pass,
RuntimeError # Fails on 7.1. Please triage this failure
On 2015/05/26 08:23:33, karlklose wrote:
> Is this a line-ending style change?

Must be.

[Johnni Winther, 2015-05-26 09:11:55]

Committed patchset #2 (id:20001) manually as
45ec43770dd32725600cca8942f27893c094a540 (presubmit successful).