Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: pkg/compiler/lib/src/resolution/send_resolver.dart

Issue 1152903003: Create SendStructure for unary and binary in resolution. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Updated cf. comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/resolution/send_resolver.dart
diff --git a/pkg/compiler/lib/src/resolution/send_resolver.dart b/pkg/compiler/lib/src/resolution/send_resolver.dart
index 4608ecd10089d6e621e8506e3538810477c65936..80071d1449ef4844b612d32e5fe0d8ed3678fee4 100644
--- a/pkg/compiler/lib/src/resolution/send_resolver.dart
+++ b/pkg/compiler/lib/src/resolution/send_resolver.dart
@@ -222,10 +222,8 @@ abstract class SendResolverMixin {
return internalError(node, "Unexpected is test.");
} else if (operatorText == 'as') {
return internalError(node, "Unexpected as cast.");
- return new AsStructure(elements.getType(node.arguments.single));
} else if (operatorText == '&&') {
return internalError(node, "Unexpected logical and.");
- return const LogicalAndStructure();
} else if (operatorText == '||') {
return internalError(node, "Unexpected logical or.");
}
@@ -357,18 +355,17 @@ abstract class SendResolverMixin {
}
return new InvokeStructure(semantics, selector);
case SendStructureKind.UNARY:
- return new UnaryStructure(semantics, unaryOperator, selector);
+ return internalError(node, "Unexpected unary.");
case SendStructureKind.NOT:
- assert(selector == null);
- return new NotStructure(semantics, selector);
+ return internalError(node, "Unexpected not.");
case SendStructureKind.BINARY:
- return new BinaryStructure(semantics, binaryOperator, selector);
+ return internalError(node, "Unexpected binary.");
case SendStructureKind.INDEX:
- return new IndexStructure(semantics, selector);
+ return internalError(node, "Unexpected index.");
case SendStructureKind.EQ:
- return new EqualsStructure(semantics, selector);
+ return internalError(node, "Unexpected equals.");
case SendStructureKind.NOT_EQ:
- return new NotEqualsStructure(semantics, selector);
+ return internalError(node, "Unexpected not equals.");
case SendStructureKind.COMPOUND:
Selector getterSelector =
elements.getGetterSelectorInComplexSendSet(node);
« no previous file with comments | « pkg/compiler/lib/src/resolution/resolution.dart ('k') | pkg/compiler/lib/src/resolution/send_structure.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698